Issue 140663004: [chromeos] Add a battery discharge rate plot to about:power page.

Issue 140663004: [chromeos] Add a battery discharge rate plot to about:power page. (Closed)

Created:
6 years, 11 months ago by Siva Chandra

Modified:
6 years, 11 months ago

Reviewers:
arv (Not doing code reviews), Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromeos] Add a battery discharge rate plot to about:power page. BUG=333087 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245349

Patch Set 2 : Address comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -17 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/power.html	View		1 chunk	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/power.js	View		1 chunk	+36 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/power_ui.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	chromeos/power/power_data_collector.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chromeos/power/power_data_collector.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM with a comment https://codereview.chromium.org/140663004/diff/1/chromeos/power/power_data_collector.cc File chromeos/power/power_data_collector.cc (right): https://codereview.chromium.org/140663004/diff/1/chromeos/power/power_data_collector.cc#newcode82 chromeos/power/power_data_collector.cc:82: battery_percent(0) { initialize battery_discharge_rate to ...

6 years, 11 months ago (2014-01-16 18:06:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/140663004/80001

6 years, 11 months ago (2014-01-16 19:28:38 UTC) #5

Message was sent while issue was closed.

Change committed as 245349

Expand Messages | Collapse Messages