Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: ui/events/latency_info.h

Issue 140663003: Removed requirement for the renderer to know it's process ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and addressed feedback from jamesr@ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/latency_info.h
diff --git a/ui/events/latency_info.h b/ui/events/latency_info.h
index 96f76fbb890ffe179fb61e3a5d37249e5693a47b..bf17a4d4cc066a3abb51ebc33550f3838b3df33d 100644
--- a/ui/events/latency_info.h
+++ b/ui/events/latency_info.h
@@ -10,6 +10,7 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/process/process_handle.h"
jbauman 2014/01/17 00:02:29 Not necessary anymore.
#include "base/time/time.h"
#include "ui/events/events_base_export.h"
@@ -134,6 +135,12 @@ struct EVENTS_BASE_EXPORT LatencyInfo {
// Records the |event_type| in trace buffer as TRACE_EVENT_ASYNC_STEP.
void TraceEventType(const char* event_type);
+ // Some LatencyComponents generated in the renderer, specifically
+ // WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENTs, require a ProcessId to route
jbauman 2014/01/17 00:02:29 Not a ProcessId anymore.
+ // notifications correctly. Since that cannot be given in the renderer
+ // this function patches the ProcessId in from the browser process.
+ void FixMissingComponentIds(int64 component_id);
jbauman 2014/01/17 00:02:29 Could you put this on RenderWidgetHostImpl instead
+
LatencyMap latency_components;
// The unique id for matching the ASYNC_BEGIN/END trace event.
int64 trace_id;

Powered by Google App Engine
This is Rietveld 408576698