Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: content/renderer/render_thread_impl.h

Issue 140663003: Removed requirement for the renderer to know it's process ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and addressed feedback from jamesr@ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.h
diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h
index 05b18f2a75052ef936781bb6eca7f4f6617b5925..79a1b6e04bddef6bf906ccab74c0ba61ee9123b0 100644
--- a/content/renderer/render_thread_impl.h
+++ b/content/renderer/render_thread_impl.h
@@ -12,7 +12,6 @@
#include "base/memory/memory_pressure_listener.h"
#include "base/metrics/user_metrics_action.h"
#include "base/observer_list.h"
-#include "base/process/process_handle.h"
#include "base/strings/string16.h"
#include "base/threading/thread_checker.h"
#include "base/timer/timer.h"
@@ -340,10 +339,6 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,
// Retrieve current gamepad data.
void SampleGamepads(blink::WebGamepads* data);
- // DO NOT USE THIS METHOD!
- // TODO(kbr): remove: crbug.com/333501
- base::ProcessId renderer_process_id() const;
-
// Called by a RenderWidget when it is created or destroyed. This
// allows the process to know when there are no visible widgets.
void WidgetCreated();
@@ -386,7 +381,6 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,
void OnNetworkStateChanged(bool online);
void OnGetAccessibilityTree();
void OnTempCrashWithData(const GURL& data);
- void OnSetRendererProcessID(base::ProcessId process_id);
void OnMemoryPressure(
base::MemoryPressureListener::MemoryPressureLevel memory_pressure_level);
#if defined(OS_ANDROID)
@@ -500,8 +494,6 @@ class CONTENT_EXPORT RenderThreadImpl : public RenderThread,
scoped_ptr<GamepadSharedMemoryReader> gamepad_shared_memory_reader_;
- base::ProcessId renderer_process_id_;
-
// TODO(reveman): Allow AllocateGpuMemoryBuffer to be called from
// multiple threads. Current allocation mechanism for IOSurface
// backed GpuMemoryBuffers prevent this. crbug.com/325045

Powered by Google App Engine
This is Rietveld 408576698