Measure usage of the prefixed encrypted media APIs

Measure usage of the prefixed encrypted media APIs

The unprefixed replacements for these aren't implemented yet, but it's
just as well to start collecting data early.

PrefixedMediaGenerateKeyRequest and PrefixedMediaAddKey were already in
UseCounter.h, but unused. Add the missing PrefixedMediaCancelKeyRequest
and put them all to use.

Remove the deprecation message for PrefixedMediaGenerateKeyRequest,
which was left behind in r150962. Otherwise, the ASSERTs in
UseCounter::count would start failing.

BUG=334983
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165290

[acolwell GONE FROM CHROMIUM, 2014-01-16 18:07:15]

lgtm

[ddorwin, 2014-01-16 18:14:29]

Thanks. We really only need the GKR one, but it's up to you or others whether we
should use the existing two or track all three.

LGTM.

https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter.h
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.h:288: PrefixedMediaCancelKeyRequest,
We don't really need this. Nobody is using it. We don't even really need the
AddKey one since GenerateKeyRequest must be called first.

(canPlayType's keySystem parameter and webkitGenerateKeyRequest() are the
entrypoints to prefixed EME.)

[philipj_slow, 2014-01-16 18:46:19]

https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter.h
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.h:288: PrefixedMediaCancelKeyRequest,
On 2014/01/16 18:14:30, ddorwin wrote:
> We don't really need this. Nobody is using it. We don't even really need the
> AddKey one since GenerateKeyRequest must be called first.
> 
> (canPlayType's keySystem parameter and webkitGenerateKeyRequest() are the
> entrypoints to prefixed EME.)

I see what you're saying about one call being meaningless without the other, but
the fullscreen API is similar and has counters for all functions... it helps to
remove any doubt in an intent to deprecate and remove. Honestly I hadn't thought
about it before, but for simplicity I'll go with this, unless you object.

[ddorwin, 2014-01-16 20:56:54]

On 2014/01/16 18:46:19, philipj wrote:
>
https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter.h
> File Source/core/frame/UseCounter.h (right):
> 
>
https://codereview.chromium.org/140663002/diff/1/Source/core/frame/UseCounter...
> Source/core/frame/UseCounter.h:288: PrefixedMediaCancelKeyRequest,
> On 2014/01/16 18:14:30, ddorwin wrote:
> > We don't really need this. Nobody is using it. We don't even really need the
> > AddKey one since GenerateKeyRequest must be called first.
> > 
> > (canPlayType's keySystem parameter and webkitGenerateKeyRequest() are the
> > entrypoints to prefixed EME.)
> 
> I see what you're saying about one call being meaningless without the other,
but
> the fullscreen API is similar and has counters for all functions... it helps
to
> remove any doubt in an intent to deprecate and remove. Honestly I hadn't
thought
> about it before, but for simplicity I'll go with this, unless you object.

Still LGTM.

[commit-bot: I haz the power, 2014-01-17 00:12:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140663002/1

[commit-bot: I haz the power, 2014-01-17 01:27:15]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-17 03:16:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140663002/150001

[commit-bot: I haz the power, 2014-01-17 03:59:28]

Retried try job too often on linux_blink for step(s) webkit_unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-17 06:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140663002/150001

[commit-bot: I haz the power, 2014-01-17 06:59:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/140663002/300001

[commit-bot: I haz the power, 2014-01-17 08:31:05]

Change committed as 165290