Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 1406613002: For some vector icons, get the size from the vector definition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 5 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/i18n/number_formatting.h" 10 #include "base/i18n/number_formatting.h"
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 PopupTopSpacing() + (GetWidget()->ShouldWindowContentsBeTransparent() ? 764 PopupTopSpacing() + (GetWidget()->ShouldWindowContentsBeTransparent() ?
765 kPopupBottomSpacingGlass : kPopupBottomSpacingNonGlass)); 765 kPopupBottomSpacingGlass : kPopupBottomSpacingNonGlass));
766 } 766 }
767 return size; 767 return size;
768 } 768 }
769 769
770 void ToolbarView::LoadImages() { 770 void ToolbarView::LoadImages() {
771 ui::ThemeProvider* tp = GetThemeProvider(); 771 ui::ThemeProvider* tp = GetThemeProvider();
772 772
773 if (ui::MaterialDesignController::IsModeMaterial()) { 773 if (ui::MaterialDesignController::IsModeMaterial()) {
774 const int kButtonSize = 16;
775 const SkColor normal_color = 774 const SkColor normal_color =
776 tp->GetColor(ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON); 775 tp->GetColor(ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);
777 const SkColor disabled_color = 776 const SkColor disabled_color =
778 tp->GetColor(ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON_INACTIVE); 777 tp->GetColor(ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON_INACTIVE);
779 778
780 back_->SetImage(views::Button::STATE_NORMAL, 779 back_->SetImage(views::Button::STATE_NORMAL,
781 gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_BACK, 780 gfx::CreatePrimaryVectorIcon(
782 kButtonSize, normal_color)); 781 gfx::VectorIconId::NAVIGATE_BACK, normal_color));
783 back_->SetImage(views::Button::STATE_DISABLED, 782 back_->SetImage(views::Button::STATE_DISABLED,
784 gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_BACK, 783 gfx::CreatePrimaryVectorIcon(
785 kButtonSize, disabled_color)); 784 gfx::VectorIconId::NAVIGATE_BACK, disabled_color));
786 forward_->SetImage( 785 forward_->SetImage(views::Button::STATE_NORMAL,
787 views::Button::STATE_NORMAL, 786 gfx::CreatePrimaryVectorIcon(
788 gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_FORWARD, kButtonSize, 787 gfx::VectorIconId::NAVIGATE_FORWARD, normal_color));
789 normal_color));
790 forward_->SetImage( 788 forward_->SetImage(
791 views::Button::STATE_DISABLED, 789 views::Button::STATE_DISABLED,
792 gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_FORWARD, kButtonSize, 790 gfx::CreatePrimaryVectorIcon(gfx::VectorIconId::NAVIGATE_FORWARD,
793 disabled_color)); 791 disabled_color));
794 home_->SetImage(views::Button::STATE_NORMAL, 792 home_->SetImage(views::Button::STATE_NORMAL,
795 gfx::CreateVectorIcon(gfx::VectorIconId::NAVIGATE_HOME, 793 gfx::CreatePrimaryVectorIcon(
796 kButtonSize, normal_color)); 794 gfx::VectorIconId::NAVIGATE_HOME, normal_color));
797 app_menu_button_->UpdateIcon(); 795 app_menu_button_->UpdateIcon();
798 } else { 796 } else {
799 back_->SetImage(views::Button::STATE_NORMAL, 797 back_->SetImage(views::Button::STATE_NORMAL,
800 *(tp->GetImageSkiaNamed(IDR_BACK))); 798 *(tp->GetImageSkiaNamed(IDR_BACK)));
801 back_->SetImage(views::Button::STATE_DISABLED, 799 back_->SetImage(views::Button::STATE_DISABLED,
802 *(tp->GetImageSkiaNamed(IDR_BACK_D))); 800 *(tp->GetImageSkiaNamed(IDR_BACK_D)));
803 forward_->SetImage(views::Button::STATE_NORMAL, 801 forward_->SetImage(views::Button::STATE_NORMAL,
804 *(tp->GetImageSkiaNamed(IDR_FORWARD))); 802 *(tp->GetImageSkiaNamed(IDR_FORWARD)));
805 forward_->SetImage(views::Button::STATE_DISABLED, 803 forward_->SetImage(views::Button::STATE_DISABLED,
806 *(tp->GetImageSkiaNamed(IDR_FORWARD_D))); 804 *(tp->GetImageSkiaNamed(IDR_FORWARD_D)));
(...skipping 22 matching lines...) Expand all
829 void ToolbarView::OnShowHomeButtonChanged() { 827 void ToolbarView::OnShowHomeButtonChanged() {
830 Layout(); 828 Layout();
831 SchedulePaint(); 829 SchedulePaint();
832 } 830 }
833 831
834 int ToolbarView::content_shadow_height() const { 832 int ToolbarView::content_shadow_height() const {
835 return GetLayoutConstant( 833 return GetLayoutConstant(
836 (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) ? 834 (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) ?
837 TOOLBAR_CONTENT_SHADOW_HEIGHT_ASH : TOOLBAR_CONTENT_SHADOW_HEIGHT); 835 TOOLBAR_CONTENT_SHADOW_HEIGHT_ASH : TOOLBAR_CONTENT_SHADOW_HEIGHT);
838 } 836 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698