Issue 14066013: Revert 194348 "Part of multiprofile implementation."

Issue 14066013: Revert 194348 "Part of multiprofile implementation." (Closed)

Created:
7 years, 8 months ago by flackr

Modified:
7 years, 8 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 194348 "Part of multiprofile implementation." Failing browser_tests on linux chromiumos. > Part of multiprofile implementation. > > Created method for obtaining signin profile. > Signin profile used instead of "DefaultProfile" during login phase. > > R=nkostylev@chromium.org > TBR=brettw > > Review URL: https://codereview.chromium.org/13633003 TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194362

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -113 lines)			Patch
M	trunk/src/chrome/browser/chromeos/login/base_login_display_host.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/captive_portal_window_proxy.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/help_app_launcher.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/login_performer.cc	View	3 chunks	+11 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/login_utils.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/login_web_dialog.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/proxy_settings_dialog.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/user_manager_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/webui_login_view.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/profile_startup.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/chromeos/profile_startup.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/profiles/profile_helper.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/profiles/profile_helper.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/sms_observer.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/sms_observer.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/startup/startup_browser_creator.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_chromeos.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

On 2013/04/16 14:41:06, flackr wrote: > Committed patchset #1 manually as r194362. @flackr, please provide ...

7 years, 8 months ago (2013-04-17 08:15:09 UTC) #3

flackr

On 2013/04/17 08:15:09, dzhioev wrote: > On 2013/04/16 14:41:06, flackr wrote: > > Committed patchset ...

7 years, 8 months ago (2013-04-17 11:51:58 UTC) #4

flackr

7 years, 8 months ago (2013-04-17 12:49:14 UTC) #5

Message was sent while issue was closed.

On 2013/04/17 11:51:58, flackr wrote:
> On 2013/04/17 08:15:09, dzhioev wrote:
> > On 2013/04/16 14:41:06, flackr wrote:
> > > Committed patchset #1 manually as r194362.
> > 
> > @flackr, please provide link to broken tests next time.
> 
> Sure will do, FYI
>
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%252...

Sorry, phone messed up that link, here it is again:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...

Expand Messages | Collapse Messages