Issue 14066011: Move kEulaAccepted pref name to chrome/common/pref_names.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14066011: Move kEulaAccepted pref name to chrome/common/pref_names.h. (Closed)

Created:
7 years, 8 months ago by Alexei Svitkine (slow)

Modified:
7 years, 8 months ago

Reviewers:
SteveT, Nikita (slow), sky

CC:
chromium-reviews, MAD, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move kEulaAccepted pref name to chrome/common/pref_names.h. This pref will also be used by Chrome on Android and iOS, in addition to ChromeOS. BUG=226757 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194587

Patch Set 1 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -16 lines)			Patch
M	chrome/browser/chromeos/login/wizard_controller.cc	View	4 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/metrics/variations/eula_accepted_notifier_mobile.cc	View	4 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

SteveT

lgtm It's a shame that there's no good block to put the extern in pref_names.

7 years, 8 months ago (2013-04-16 15:33:13 UTC) #2

Alexei Svitkine (slow)

+nkostylev for the wizard_controller.cc change.

7 years, 8 months ago (2013-04-16 15:52:41 UTC) #3

Alexei Svitkine (slow)

7 years, 8 months ago (2013-04-17 14:04:15 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r194587 (presubmit successful).

Expand Messages | Collapse Messages