Issue 14066009: Handle OOM failures correctly in the CEntryStub when embedders set V8::IgnoreOutOfMemoryException()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14066009: Handle OOM failures correctly in the CEntryStub when embedders set V8::IgnoreOutOfMemoryException() (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle OOM failures correctly in the CEntryStub when embedders set V8::IgnoreOutOfMemoryException() BUG=chromium:231217 Committed: http://code.google.com/p/v8/source/detail?r=14279

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -4 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+8 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. Do we by any change have a short regression test for ...

7 years, 8 months ago (2013-04-16 12:09:45 UTC) #2

Jakob Kummerow

Thanks, landing. https://codereview.chromium.org/14066009/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): https://codereview.chromium.org/14066009/diff/1/src/x64/code-stubs-x64.cc#newcode4167 src/x64/code-stubs-x64.cc:4167: masm->ExternalOperand(pending_exception_address); On 2013/04/16 12:09:45, Michael Starzinger wrote: ...

7 years, 8 months ago (2013-04-16 12:13:11 UTC) #3

Jakob Kummerow

7 years, 8 months ago (2013-04-16 12:17:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r14279 (presubmit successful).

Expand Messages | Collapse Messages