src/IceInstX86BaseImpl.h - Issue 1406593003: Optimize 64-bit compares with zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86BaseImpl.h

Issue 1406593003: Optimize 64-bit compares with zero (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add isZero utility function, fix comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceInstX86BaseImpl.h

diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h

index f2e7ff224bac2c6ee337b63e6a78e0026b94c6e8..056ecfe4ff2263484106f3766561e7b0c8cdc4df 100644

--- a/src/IceInstX86BaseImpl.h

+++ b/src/IceInstX86BaseImpl.h

@@ -2092,7 +2092,6 @@ void InstX86Test<Machine>::emitIAS(const Cfg *Func) const {

return;

}

- llvm_unreachable("Nothing actually generates this so it's untested");

emitIASAsAddrOpTyGPR<Machine>(Func, Ty, Src0, Src1, AddrEmitter);

}

« no previous file with comments | « crosstest/test_icmp_main.cpp ('k') | src/IceTargetLoweringX86BaseImpl.h » ('j') | no next file with comments »