Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1406583002: Fix type of EninePlugin List<ResultDescriptor> getters. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix type of EninePlugin List<ResultDescriptor> getters. These getters were improperly typed as List<TaskDescriptor>. Due to the fact that the underlying lists they were returning were List<dynamic>, and the fact that new warnings for for-in loops haven't been implemented yet (see commit 89607f06e9ccf9274f8ada2ecd4d004dbee9fb53), no warnings or runtime errors alerted us to the incorrect type. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ec144a055abb377e8168e6bd53370b137508d727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 2 months ago (2015-10-13 16:18:23 UTC) #2
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-13 17:29:24 UTC) #3
Paul Berry
5 years, 2 months ago (2015-10-13 17:45:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec144a055abb377e8168e6bd53370b137508d727 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698