Issue 1406573003: Fix for issue 22379246 makes the API consistent between Dart_New and Dart_InvokeConstructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406573003: Fix for issue 22379246 makes the API consistent between Dart_New and Dart_InvokeConstructor. (Closed)

Created:
5 years, 2 months ago by siva

Modified:
5 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for issue 22379246 makes the API consistent between Dart_New and Dart_InvokeConstructor. BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/dcc26a888ced1fbf694e397fb647e738b729cf9a

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -12 lines)			Patch
M	runtime/include/dart_api.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		4 chunks	+13 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 2 months ago (2015-10-14 17:06:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
dcc26a888ced1fbf694e397fb647e738b729cf9a (presubmit successful).