Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issue 1406543003: GN: Add build_overrides/webrtc.gni (Closed)

Created:
5 years, 2 months ago by kjellander_chromium
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add build_overrides/webrtc.gni Provides values for the Chromium build of WebRTC. Corresponding change in WebRTC: https://codereview.webrtc.org/1403453003/ BUG=webrtc:5070, chromium:541791 TBR=brettw@chromium.org Committed: https://crrev.com/71b9d7ed0ae2e4617e3997fc3832af5a6adc5b3c Cr-Commit-Position: refs/heads/master@{#353969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed build/config/BUILD.gn change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A build_overrides/webrtc.gni View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
kjellander_chromium
Is this how it's supposed to work after https://codereview.chromium.org/1397493004 ?
5 years, 2 months ago (2015-10-13 16:41:17 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1406543003/diff/1/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/1406543003/diff/1/build/config/BUILD.gn#newcode12 build/config/BUILD.gn:12: import("//build_overrides/webrtc.gni") You don't need to add this. The only ...
5 years, 2 months ago (2015-10-13 17:28:09 UTC) #3
kjellander_chromium
PTAL https://codereview.chromium.org/1406543003/diff/1/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/1406543003/diff/1/build/config/BUILD.gn#newcode12 build/config/BUILD.gn:12: import("//build_overrides/webrtc.gni") On 2015/10/13 17:28:09, Dirk Pranke wrote: > ...
5 years, 2 months ago (2015-10-13 21:42:54 UTC) #4
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-13 22:01:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406543003/20001
5 years, 2 months ago (2015-10-14 05:58:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/109213)
5 years, 2 months ago (2015-10-14 06:06:07 UTC) #9
kjellander_chromium
On 2015/10/14 06:06:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-14 06:13:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406543003/20001
5 years, 2 months ago (2015-10-14 06:13:55 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 06:45:42 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 06:46:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71b9d7ed0ae2e4617e3997fc3832af5a6adc5b3c
Cr-Commit-Position: refs/heads/master@{#353969}

Powered by Google App Engine
This is Rietveld 408576698