Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1406543002: [turbofan] First rudimentary inlining heuristic. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] First rudimentary inlining heuristic. This is a first prototype for a rudimentary inlining heuristic allowing enabling of general inlining based existing budget flags. Also note that this approach does not yet work for multi-level inlining, for now the list of candidates is processed exactly once. R=bmeurer@chromium.org Committed: https://crrev.com/8ff6a0c005176d2493d425a210b9ab47d11c70c6 Cr-Commit-Position: refs/heads/master@{#31249}

Patch Set 1 #

Patch Set 2 : Fix compilation on 64-bit architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -5 lines) Patch
M src/compiler/js-inlining-heuristic.h View 1 chunk +21 lines, -2 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 2 chunks +83 lines, -3 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-13 14:29:48 UTC) #1
Benedikt Meurer
LGTM for landing as first step.
5 years, 2 months ago (2015-10-13 18:54:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406543002/20001
5 years, 2 months ago (2015-10-14 08:33:14 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 08:37:13 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 08:37:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ff6a0c005176d2493d425a210b9ab47d11c70c6
Cr-Commit-Position: refs/heads/master@{#31249}

Powered by Google App Engine
This is Rietveld 408576698