Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1406533002: Revert of [heap] Divide available memory upon compaction tasks (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@counters
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Divide available memory upon compaction tasks (patchset #9 id:340001 of https://codereview.chromium.org/1382003002/ ) Reason for revert: Failing tests: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/3804/steps/Check/logs/DontLeakGlobalObjects Original issue's description: > [heap] Divide available memory upon compaction tasks > > - Fairly (round-robin) divide available memory upon compaction tasks. > - Ensure an upper limit (of memory) since dividing is O(n) for n free-space > nodes. > - Refill from free lists managed by sweeper once a compaction space becomes > empty. > > Assumption for dividing memory: Memory in the free lists is sparse upon starting > compaction (which means that only few nodes are available), except for memory > reducer GCs, which happen in idle time though (so it's less of a problem). > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/30236c052ba9266fc55412a8fd63b17f683ff40b > Cr-Commit-Position: refs/heads/master@{#31234} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/ec1046f9f8cd52488917b439c598296620103d39 Cr-Commit-Position: refs/heads/master@{#31235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -368 lines) Patch
M src/heap/mark-compact.h View 2 chunks +2 lines, -14 lines 0 comments Download
M src/heap/mark-compact.cc View 4 chunks +30 lines, -7 lines 0 comments Download
M src/heap/spaces.h View 7 chunks +6 lines, -32 lines 0 comments Download
M src/heap/spaces.cc View 6 chunks +8 lines, -127 lines 0 comments Download
M test/cctest/heap-tester.h View 2 chunks +11 lines, -32 lines 0 comments Download
M test/cctest/test-spaces.cc View 4 chunks +11 lines, -156 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of [heap] Divide available memory upon compaction tasks
5 years, 2 months ago (2015-10-13 11:59:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406533002/1
5 years, 2 months ago (2015-10-13 11:59:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 12:00:09 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 12:00:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec1046f9f8cd52488917b439c598296620103d39
Cr-Commit-Position: refs/heads/master@{#31235}

Powered by Google App Engine
This is Rietveld 408576698