Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 140653006: Add support for horizontal mouse wheel messages in Windows Desktop Aura. (Closed)

Created:
6 years, 11 months ago by ananta
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for horizontal mouse wheel messages in Windows Desktop Aura. This is simply a matter of recognizing the WM_MOUSEHWHEEL message as a valid mouse wheel message. Tested this on web pages with horizontal scrollbars and it works well. BUG=332797 R=sky@chromium.org, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245651

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/events/win/events_win.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ananta
6 years, 11 months ago (2014-01-17 00:02:46 UTC) #1
sky
https://codereview.chromium.org/140653006/diff/1/ui/events/win/events_win.cc File ui/events/win/events_win.cc (right): https://codereview.chromium.org/140653006/diff/1/ui/events/win/events_win.cc#newcode274 ui/events/win/events_win.cc:274: return gfx::Vector2d(0, GET_WHEEL_DELTA_WPARAM(native_event.wParam)); WOuldn't a horizontal scroll effect the ...
6 years, 11 months ago (2014-01-17 00:35:17 UTC) #2
ananta
https://codereview.chromium.org/140653006/diff/1/ui/events/win/events_win.cc File ui/events/win/events_win.cc (right): https://codereview.chromium.org/140653006/diff/1/ui/events/win/events_win.cc#newcode274 ui/events/win/events_win.cc:274: return gfx::Vector2d(0, GET_WHEEL_DELTA_WPARAM(native_event.wParam)); On 2014/01/17 00:35:18, sky wrote: > ...
6 years, 11 months ago (2014-01-17 00:47:16 UTC) #3
sky
LGTM https://codereview.chromium.org/140653006/diff/80001/ui/events/win/events_win.cc File ui/events/win/events_win.cc (right): https://codereview.chromium.org/140653006/diff/80001/ui/events/win/events_win.cc#newcode276 ui/events/win/events_win.cc:276: else nit: no else here (see style guide)
6 years, 11 months ago (2014-01-17 15:45:40 UTC) #4
ananta
https://codereview.chromium.org/140653006/diff/80001/ui/events/win/events_win.cc File ui/events/win/events_win.cc (right): https://codereview.chromium.org/140653006/diff/80001/ui/events/win/events_win.cc#newcode276 ui/events/win/events_win.cc:276: else On 2014/01/17 15:45:40, sky wrote: > nit: no ...
6 years, 11 months ago (2014-01-17 23:16:29 UTC) #5
ananta
6 years, 11 months ago (2014-01-17 23:18:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r245651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698