Issue 140653003: Sanitize event names before adding to results object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140653003: Sanitize event names before adding to results object (Closed)

Created:
6 years, 11 months ago by nduca

Modified:
6 years, 11 months ago

Reviewers:
epennerAtGoogle, ernstm1, epenner, achuithb

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sanitize event names before adding to results object Event names can have . characters in them. But, the telemetry results system does not allow trace names to contain . characters for various reasons. R=epenner TBR=ernstm CC=achuith Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245363

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	tools/perf/metrics/timeline.py	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	tools/perf/metrics/timeline_unittest.py	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epennerAtGoogle

On 2014/01/16 17:57:53, nduca wrote: > ptal Ahh! I was sanitizing the wrong thing when ...

6 years, 11 months ago (2014-01-16 20:08:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/140653003/1

6 years, 11 months ago (2014-01-16 20:09:12 UTC) #3

achuithb

6 years, 11 months ago (2014-01-17 21:17:29 UTC) #5

Message was sent while issue was closed.

I'm still seeing the stack trace with the assertion error with "." even after
this CL. I've filed crbug.com/335692

Expand Messages | Collapse Messages