Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1406523003: Makes example use TYPE_WINDOW (Closed)

Created:
5 years, 2 months ago by sky
Modified:
5 years, 2 months ago
CC:
chromium-reviews, kalyank, sadrul, yzshen+watch_chromium.org, penghuang+watch-mandoline_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes example use TYPE_WINDOW Now that it works I can see we have rendering issues. I'll look into that separately. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/43c93b3c50a8d23b4206f325376ab5da29d44482 Cr-Commit-Position: refs/heads/master@{#353892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M components/mus/example/client/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/example/client/client_application_delegate.cc View 1 chunk +1 line, -4 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M mandoline/ui/aura/aura_init.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 2 months ago (2015-10-13 21:55:45 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 2 months ago (2015-10-13 22:14:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406523003/1
5 years, 2 months ago (2015-10-13 22:23:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 23:10:21 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:11:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43c93b3c50a8d23b4206f325376ab5da29d44482
Cr-Commit-Position: refs/heads/master@{#353892}

Powered by Google App Engine
This is Rietveld 408576698