LayoutTests/fast/media/mq-js-media-forward-syntax.html - Issue 14065029: Improved parse error handling for CSSMQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/media/mq-js-media-forward-syntax.html

Issue 14065029: Improved parse error handling for CSSMQ. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/media/mq-js-media-forward-syntax.html

diff --git a/LayoutTests/fast/media/mq-js-media-forward-syntax.html b/LayoutTests/fast/media/mq-js-media-forward-syntax.html

index 5e74cdb9f8eb6840200573c0e02a26e3c9502171..5f30daf01315655465db02bbc3c830c2cc9058cc 100644

--- a/LayoutTests/fast/media/mq-js-media-forward-syntax.html

+++ b/LayoutTests/fast/media/mq-js-media-forward-syntax.html

@@ -1,31 +1,22 @@

<html>

<head>

-<title>CSS3 media query test: stylesheet media.mediaText = parsing, media descriptor fallback in document.StyleSheet.media.mediaText</title>

+<title>CSS3 media query test: stylesheet media.mediaText = parsing, media descriptors not accepted</title>

<!-- the media property of stylesheet below will be manipulated, and

- manipulation should respect html media descriptor forward-compatible syntax.

- This means the manipulation should succeed. -->

+ manipulation should respect media queries error handling.

+ This means the manipulation should succeed and set media to 'not all'. -->

-p#result { color: green;}

-@media screen and resolution > 40dpi {

-/* media query with syntax error should fail */

-/* corresponding DOM manipulation to the mediaText of the stylesheet will succeed */

p#result { color: red;}

</style>

function test() {

- // this should not throw, because StyleSheet should respect Media Description forward-compatible syntax

+ // Setting mediaText should not throw according to the CSSOM spec and yield

+ // 'not all' according to the Media Queries spec.

document.styleSheets[0].media.mediaText = "screen and resolution > 40dpi";

- document.getElementById("result").innerHTML = "This text should be green.";

+ document.getElementById("result").innerHTML = "This text should not be red.";

}

</script>

</head>

<p id="result">Failure: test not run</p>