Add support for typed data views on native threads

runtime/vm/dart_api_message.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_DART_API_MESSAGE_H_
 #define VM_DART_API_MESSAGE_H_
 
 #include "vm/dart_api_state.h"
 #include "vm/snapshot.h"
 
 namespace dart {
 
 // Use this C structure for reading internal objects in the serialized
 // data. These are objects that we need to process in order to
 // generate the Dart_CObject graph but that we don't want to expose in
 // that graph.
 // TODO(sjesse): Remove this when message serialization format is

[Mads Ager (google), 2013/04/11 05:57:04]

Update this TODO with a bug report with more information about the proposed
changes to the message serialization format? Or maybe just remove the TODO?

[Søren Gjesse, 2013/04/11 06:47:27]

I removed the TODO. At some point there where rumors that serialization for
messages should be simpler than snapshot serialization. I am not sure where that
stands at the moment. For now we need this even more to read views.

 // updated.
 struct Dart_CObject_Internal : public Dart_CObject {
   enum Type {
     kTypeArguments = Dart_CObject::kNumberOfTypes,
     kDynamicType,
+    kClass,
+    kView,
+    kUninitialized,
   };
+  struct Dart_CObject_Internal* cls;
+  union {
+    struct {
+      struct _Dart_CObject* library_url;
+      struct _Dart_CObject* class_name;
+    } as_class;
+    struct {
+      struct _Dart_CObject* buffer;
+      int offset_in_bytes;
+      int length;
+    } as_view;
+  } internal;
 };
 
 
 // Reads a message snapshot into a C structure.
 class ApiMessageReader : public BaseReader {
  public:
   // The allocator passed is used to allocate memory for the C structure used
   // to represent the message snapshot. This allocator must keep track of the
   // memory allocated as there is no way to run through the resulting C
   // structure and free the individual pieces. Using a zone based allocator is
@@ skipping 38 matching lines @@
   // Allocates a Dart_CObject object for bigint data.
   Dart_CObject* AllocateDartCObjectBigint(intptr_t length);
   // Allocates a Dart_CObject object for a double.
   Dart_CObject* AllocateDartCObjectDouble(double value);
   // Allocates a Dart_CObject object for string data.
   Dart_CObject* AllocateDartCObjectString(intptr_t length);
   // Allocates a C Dart_CObject object for byte data.
   Dart_CObject* AllocateDartCObjectUint8Array(intptr_t length);
   // Allocates a C array of Dart_CObject objects.
   Dart_CObject* AllocateDartCObjectArray(intptr_t length);
+  // Allocates a Dart_CObject_Internal object with the specified type.
+  Dart_CObject_Internal* AllocateDartCObjectInternal(
+      Dart_CObject_Internal::Type type);
+  // Allocates a Dart_CObject_Internal object for a class object.
+  Dart_CObject_Internal* AllocateDartCObjectClass();
   // Allocates a backwards reference node.
   BackRefNode* AllocateBackRefNode(Dart_CObject* ref, DeserializeState state);
 
   void Init();
 
   intptr_t LookupInternalClass(intptr_t class_header);
   Dart_CObject* ReadVMIsolateObject(intptr_t value);
   Dart_CObject* ReadInternalVMObject(intptr_t class_id, intptr_t object_id);
   Dart_CObject* ReadInlinedObject(intptr_t object_id);
   Dart_CObject* ReadObjectImpl();
@@ skipping 72 matching lines @@
   Dart_CObject** forward_list_;
   intptr_t forward_list_length_;
   intptr_t forward_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ApiMessageWriter);
 };
 
 }  // namespace dart
 
 #endif  // VM_DART_API_MESSAGE_H_