build/android/envsetup_functions.sh - Issue 14065005: Introduce arm_version to allow building for armv5, v6 or v7.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/envsetup_functions.sh

Issue 14065005: Introduce arm_version to allow building for armv5, v6 or v7. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review issues Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/envsetup_functions.sh

diff --git a/build/android/envsetup_functions.sh b/build/android/envsetup_functions.sh

index 3c7e58f6def5b4483f677bf1a3139fb45a5c7630..7d3e9ad17495b370aaf0650cd93ec32cbabfc768 100755

--- a/build/android/envsetup_functions.sh

+++ b/build/android/envsetup_functions.sh

@@ -106,7 +106,6 @@ common_vars_defines() {

# and V8 mksnapshot.

case "${TARGET_ARCH}" in

"arm")

- DEFINES+=" arm_neon=0 armv7=1 arm_thumb=1 arm_fpu=vfpv3-d16"

DEFINES+=" arm_neon_optional=1" # Enable dynamic NEON support.

Yaron 2013/04/12 16:35:33 One more to go.. can you push this one into gyp to

Fredrik Öhrn 2013/04/12 17:05:25 Of course, I'll do it first thing Monday.

DEFINES+=" ${ORDER_DEFINES}"

DEFINES+=" target_arch=arm"

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »