Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: skia/skia.gyp

Issue 14065005: Introduce arm_version to allow building for armv5, v6 or v7. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review issues Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'skia', 8 'target_name': 'skia',
9 'type': '<(component)', 9 'type': '<(component)',
10 'variables': { 10 'variables': {
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 }], 333 }],
334 [ 'OS != "mac"', { 334 [ 'OS != "mac"', {
335 'sources/': [ 335 'sources/': [
336 ['exclude', '_mac\\.(cc|cpp|mm?)$'], 336 ['exclude', '_mac\\.(cc|cpp|mm?)$'],
337 ['exclude', '/mac/'] 337 ['exclude', '/mac/']
338 ], 338 ],
339 }], 339 }],
340 [ 'OS != "win"', { 340 [ 'OS != "win"', {
341 'sources/': [ ['exclude', '_win\\.(cc|cpp)$'] ], 341 'sources/': [ ['exclude', '_win\\.(cc|cpp)$'] ],
342 }], 342 }],
343 [ 'armv7 == 1', { 343 [ 'arm_version >= 7 and arm_neon == 1', {
344 'defines': [
345 '__ARM_ARCH__=7',
346 ],
347 }],
348 [ 'armv7 == 1 and arm_neon == 1', {
349 'defines': [ 344 'defines': [
350 '__ARM_HAVE_NEON', 345 '__ARM_HAVE_NEON',
351 ], 346 ],
352 }], 347 }],
353 [ 'target_arch == "arm" or target_arch == "mipsel"', { 348 [ 'target_arch == "arm" or target_arch == "mipsel"', {
354 'sources!': [ 349 'sources!': [
355 '../third_party/skia/src/opts/opts_check_SSE2.cpp' 350 '../third_party/skia/src/opts/opts_check_SSE2.cpp'
356 ], 351 ],
357 }], 352 }],
358 [ 'use_glib == 1', { 353 [ 'use_glib == 1', {
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 # x86 Android doesn't support SSSE3 instructions. 659 # x86 Android doesn't support SSSE3 instructions.
665 [ 'OS != "android"', { 660 [ 'OS != "android"', {
666 'dependencies': [ 661 'dependencies': [
667 'skia_opts_ssse3', 662 'skia_opts_ssse3',
668 ], 663 ],
669 }], 664 }],
670 ], 665 ],
671 }], 666 }],
672 [ 'target_arch == "arm"', { 667 [ 'target_arch == "arm"', {
673 'conditions': [ 668 'conditions': [
674 [ 'armv7 == 1', { 669 [ 'arm_version >= 7 and arm_neon == 1', {
675 'defines': [
676 '__ARM_ARCH__=7',
677 ],
678 }],
679 [ 'armv7 == 1 and arm_neon == 1', {
680 'defines': [ 670 'defines': [
681 '__ARM_HAVE_NEON', 671 '__ARM_HAVE_NEON',
682 ], 672 ],
683 'cflags': [ 673 'cflags': [
684 # The neon assembly contains conditional instructions which 674 # The neon assembly contains conditional instructions which
685 # aren't enclosed in an IT block. The assembler complains 675 # aren't enclosed in an IT block. The assembler complains
686 # without this option. 676 # without this option.
687 # See #86592. 677 # See #86592.
688 '-Wa,-mimplicit-it=always', 678 '-Wa,-mimplicit-it=always',
689 ], 679 ],
690 }], 680 }],
691 ], 681 ],
692 # The assembly uses the frame pointer register (r7 in Thumb/r11 in 682 # The assembly uses the frame pointer register (r7 in Thumb/r11 in
693 # ARM), the compiler doesn't like that. Explicitly remove the 683 # ARM), the compiler doesn't like that. Explicitly remove the
694 # -fno-omit-frame-pointer flag for Android, as that gets added to all 684 # -fno-omit-frame-pointer flag for Android, as that gets added to all
695 # targets via common.gypi. 685 # targets via common.gypi.
696 'cflags!': [ 686 'cflags!': [
697 '-fno-omit-frame-pointer', 687 '-fno-omit-frame-pointer',
698 '-marm', 688 '-marm',
699 '-mapcs-frame', 689 '-mapcs-frame',
700 ], 690 ],
701 'cflags': [ 691 'cflags': [
702 '-fomit-frame-pointer', 692 '-fomit-frame-pointer',
703 ], 693 ],
704 'sources': [ 694 'sources': [
705 '../third_party/skia/src/opts/SkBitmapProcState_opts_arm.cpp', 695 '../third_party/skia/src/opts/SkBitmapProcState_opts_arm.cpp',
706 ], 696 ],
707 }], 697 }],
708 [ 'armv7 == 1 and arm_neon == 0', { 698 [ 'target_arch == "arm" and (arm_version < 7 or arm_neon == 0)', {
709 'sources': [ 699 'sources': [
710 '../third_party/skia/src/opts/memset.arm.S', 700 '../third_party/skia/src/opts/memset.arm.S',
711 ], 701 ],
712 }], 702 }],
713 [ 'armv7 == 1 and arm_neon == 1', { 703 [ 'target_arch == "arm" and arm_version >= 7 and arm_neon == 1', {
714 'sources': [ 704 'sources': [
715 '../third_party/skia/src/opts/memset16_neon.S', 705 '../third_party/skia/src/opts/memset16_neon.S',
716 '../third_party/skia/src/opts/memset32_neon.S', 706 '../third_party/skia/src/opts/memset32_neon.S',
717 '../third_party/skia/src/opts/SkBitmapProcState_arm_neon.cpp', 707 '../third_party/skia/src/opts/SkBitmapProcState_arm_neon.cpp',
718 '../third_party/skia/src/opts/SkBitmapProcState_matrixProcs_neon.cpp ', 708 '../third_party/skia/src/opts/SkBitmapProcState_matrixProcs_neon.cpp ',
719 '../third_party/skia/src/opts/SkBitmapProcState_matrix_clamp_neon.h' , 709 '../third_party/skia/src/opts/SkBitmapProcState_matrix_clamp_neon.h' ,
720 '../third_party/skia/src/opts/SkBitmapProcState_matrix_repeat_neon.h ', 710 '../third_party/skia/src/opts/SkBitmapProcState_matrix_repeat_neon.h ',
721 '../third_party/skia/src/opts/SkBlitRow_opts_arm_neon.cpp', 711 '../third_party/skia/src/opts/SkBlitRow_opts_arm_neon.cpp',
722 ], 712 ],
723 }], 713 }],
724 [ 'target_arch == "arm" and armv7 == 0', { 714 [ 'target_arch == "arm" and arm_version < 6', {
725 'sources': [ 715 'sources': [
726 '../third_party/skia/src/opts/SkBlitRow_opts_none.cpp', 716 '../third_party/skia/src/opts/SkBlitRow_opts_none.cpp',
727 '../third_party/skia/src/opts/SkUtils_opts_none.cpp', 717 '../third_party/skia/src/opts/SkUtils_opts_none.cpp',
728 ], 718 ],
729 }], 719 }],
730 [ 'target_arch == "arm" and armv7 == 1', { 720 [ 'target_arch == "arm" and arm_version >= 6', {
731 'sources': [ 721 'sources': [
732 '../third_party/skia/src/opts/SkBlitRow_opts_arm.cpp', 722 '../third_party/skia/src/opts/SkBlitRow_opts_arm.cpp',
733 '../third_party/skia/src/opts/SkBlitRow_opts_arm.h', 723 '../third_party/skia/src/opts/SkBlitRow_opts_arm.h',
734 '../third_party/skia/src/opts/opts_check_arm.cpp', 724 '../third_party/skia/src/opts/opts_check_arm.cpp',
735 ], 725 ],
736 }], 726 }],
737 [ 'target_arch == "mipsel"',{ 727 [ 'target_arch == "mipsel"',{
738 'cflags': [ 728 'cflags': [
739 '-fomit-frame-pointer', 729 '-fomit-frame-pointer',
740 ], 730 ],
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 'sources': [ 821 'sources': [
832 '../third_party/skia/src/opts/SkBitmapProcState_opts_none.cpp', 822 '../third_party/skia/src/opts/SkBitmapProcState_opts_none.cpp',
833 '../third_party/skia/src/opts/SkBlitRow_opts_none.cpp', 823 '../third_party/skia/src/opts/SkBlitRow_opts_none.cpp',
834 '../third_party/skia/src/opts/SkUtils_opts_none.cpp', 824 '../third_party/skia/src/opts/SkUtils_opts_none.cpp',
835 ], 825 ],
836 }, 826 },
837 ], 827 ],
838 }], 828 }],
839 ], 829 ],
840 } 830 }
OLDNEW
« build/common.gypi ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698