Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1406483002: Move XP-only failures of artificial tests to NeverFixTests (Closed)

Created:
5 years, 2 months ago by kojii
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move XP-only failures of artificial tests to NeverFixTests These test are artificial to test every Unicode code point, which contains some invalid sequence that fail on old platforms. BUG=539425 Committed: https://crrev.com/08b1423410f7d3acbd78e735b8c6ff850f2d1cd2 Cr-Commit-Position: refs/heads/master@{#353681}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/NeverFixTests View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kojii
PTAL.
5 years, 2 months ago (2015-10-13 04:47:07 UTC) #2
tkent
lgtm
5 years, 2 months ago (2015-10-13 04:56:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406483002/20001
5 years, 2 months ago (2015-10-13 04:57:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 05:04:03 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 05:04:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08b1423410f7d3acbd78e735b8c6ff850f2d1cd2
Cr-Commit-Position: refs/heads/master@{#353681}

Powered by Google App Engine
This is Rietveld 408576698