Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1406433002: Move text-indent property into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move text-indent property into CSSPropertyParser Move text-indent property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/bbb720adf7141305c63fa98e9482a7f1efd145d1 Cr-Commit-Position: refs/heads/master@{#353743}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -45 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 3 chunks +1 line, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL.
5 years, 2 months ago (2015-10-13 02:28:34 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/1406433002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1406433002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode675 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:675: // <length> | <percentage> | inherit when RuntimeEnabledFeatures::css3TextEnabled() ...
5 years, 2 months ago (2015-10-13 05:32:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406433002/20001
5 years, 2 months ago (2015-10-13 13:03:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 14:28:52 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 14:29:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bbb720adf7141305c63fa98e9482a7f1efd145d1
Cr-Commit-Position: refs/heads/master@{#353743}

Powered by Google App Engine
This is Rietveld 408576698