Update documentation on Symbol. Make validation match.

runtime/vm/service_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_debugger_api.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/globals.h"
 #include "vm/message_handler.h"
@@ skipping 314 matching lines @@
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"999999 is not a valid class id.\","
     "\"message\":{\"arguments\":[\"classes\",\"999999\"],"
     "\"option_keys\":[],\"option_values\":[]}}", handler.msg());
 
   // Request the class A over the service.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "'], [], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
-      "{\"type\":\"Class\",\"id\":\"classes\\/1009\",\"name\":\"A\","
+      "{\"type\":\"Class\",\"id\":\"classes\\/1010\",\"name\":\"A\","

[floitsch, 2014/01/31 14:37:24]

Lasse just committed a similar change.
You might need to rebase/merge.

[Lasse Reichstein Nielsen, 2014/01/31 18:19:26]

I know :)

       "\"user_name\":\"A\",\"implemented\":false,\"abstract\":false,"
       "\"patch\":false,\"finalized\":true,\"const\":false,\"super\":"
       "{\"type\":\"@Class\",\"id\":\"classes\\/35\",\"name\":\"Object\","
       "\"user_name\":\"Object\"},\"library\":{\"type\":\"@Library\",\"id\":"
       "\"libraries\\/12\",\"name\":\"\",\"user_name\":\"dart:test-lib\"},"
-      "\"fields\":[{\"type\":\"@Field\",\"id\":\"classes\\/1009\\/fields\\/0\","
+      "\"fields\":[{\"type\":\"@Field\",\"id\":\"classes\\/1010\\/fields\\/0\","
       "\"name\":\"a\",\"user_name\":\"a\",\"owner\":{\"type\":\"@Class\","
-      "\"id\":\"classes\\/1009\",\"name\":\"A\",\"user_name\":\"A\"},"
+      "\"id\":\"classes\\/1010\",\"name\":\"A\",\"user_name\":\"A\"},"
       "\"declared_type\":{\"type\":\"@Class\",\"id\":\"classes\\/106\","
       "\"name\":\"dynamic\",\"user_name\":\"dynamic\"},\"static\":false,"
       "\"final\":false,\"const\":false}],\"functions\":["
-      "{\"type\":\"@Function\",\"id\":\"classes\\/1009\\/functions\\/0\","
+      "{\"type\":\"@Function\",\"id\":\"classes\\/1010\\/functions\\/0\","
       "\"name\":\"get:a\",\"user_name\":\"A.a\"},{\"type\":\"@Function\","
-      "\"id\":\"classes\\/1009\\/functions\\/1\",\"name\":\"set:a\","
+      "\"id\":\"classes\\/1010\\/functions\\/1\",\"name\":\"set:a\","
       "\"user_name\":\"A.a=\"},{\"type\":\"@Function\",\"id\":"
-      "\"classes\\/1009\\/functions\\/2\",\"name\":\"b\",\"user_name\":\"A.b\"}"
-      ",{\"type\":\"@Function\",\"id\":\"classes\\/1009\\/functions\\/3\","
+      "\"classes\\/1010\\/functions\\/2\",\"name\":\"b\",\"user_name\":\"A.b\"}"
+      ",{\"type\":\"@Function\",\"id\":\"classes\\/1010\\/functions\\/3\","
       "\"name\":\"c\",\"user_name\":\"A.c\"},{\"type\":\"@Function\",\"id\":"
-      "\"classes\\/1009\\/functions\\/4\",\"name\":\"A.\",\"user_name\":"
+      "\"classes\\/1010\\/functions\\/4\",\"name\":\"A.\",\"user_name\":"
       "\"A.A\"}]}",
       handler.msg());
 
   // Request function 0 from class A.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'functions', '0'],"
                               "[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
-    "{\"type\":\"Function\",\"id\":\"classes\\/1009\\/functions\\/0\",\"name\":"
+    "{\"type\":\"Function\",\"id\":\"classes\\/1010\\/functions\\/0\",\"name\":"
     "\"get:a\",\"user_name\":\"A.a\",\"is_static\":false,\"is_const\":false,"
     "\"is_optimizable\":true,\"is_inlinable\":false,\"kind\":"
     "\"kImplicitGetter\",\"unoptimized_code\":{\"type\":\"null\"},"
     "\"usage_counter\":0,\"optimized_call_site_count\":0,\"code\":"
     "{\"type\":\"null\"},\"deoptimizations\":0}", handler.msg());
 
   // Request field 0 from class A.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'fields', '0'],"
                               "[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
-    "{\"type\":\"Field\",\"id\":\"classes\\/1009\\/fields\\/0\",\"name\":\"a\","
+    "{\"type\":\"Field\",\"id\":\"classes\\/1010\\/fields\\/0\",\"name\":\"a\","
     "\"user_name\":\"a\",\"owner\":{\"type\":\"@Class\",\"id\":"
-    "\"classes\\/1009\",\"name\":\"A\",\"user_name\":\"A\"},\"declared_type\":"
+    "\"classes\\/1010\",\"name\":\"A\",\"user_name\":\"A\"},\"declared_type\":"
     "{\"type\":\"@Class\",\"id\":\"classes\\/106\",\"name\":\"dynamic\","
     "\"user_name\":\"dynamic\"},\"static\":false,\"final\":false,\"const\":"
     "false,\"guard_nullable\":true,\"guard_class\":{\"type\":\"@Class\","
     "\"id\":\"classes\\/105\",\"name\":\"Null\",\"user_name\":\"Null\"},"
     "\"guard_length\":\"variable\"}", handler.msg());
 
   // Invalid sub command.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'huh', '0'],"
                               "[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"Invalid sub collection huh\",\"message\":"
-    "{\"arguments\":[\"classes\",\"1009\",\"huh\",\"0\"],\"option_keys\":[],"
+    "{\"arguments\":[\"classes\",\"1010\",\"huh\",\"0\"],\"option_keys\":[],"
     "\"option_values\":[]}}", handler.msg());
 
   // Invalid field request.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'fields', '9'],"
                               "[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"Field 9 not found\","
-    "\"message\":{\"arguments\":[\"classes\",\"1009\",\"fields\",\"9\"],"
+    "\"message\":{\"arguments\":[\"classes\",\"1010\",\"fields\",\"9\"],"
     "\"option_keys\":[],\"option_values\":[]}}", handler.msg());
 
   // Invalid function request.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'functions', '9'],"
                               "[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"Function 9 not found\","
-    "\"message\":{\"arguments\":[\"classes\",\"1009\",\"functions\",\"9\"],"
+    "\"message\":{\"arguments\":[\"classes\",\"1010\",\"functions\",\"9\"],"
     "\"option_keys\":[],\"option_values\":[]}}", handler.msg());
 
 
   // Invalid field subcommand.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'fields', '9', 'x']"
                              ",[], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"Command too long\",\"message\":"
-    "{\"arguments\":[\"classes\",\"1009\",\"fields\",\"9\",\"x\"],"
+    "{\"arguments\":[\"classes\",\"1010\",\"fields\",\"9\",\"x\"],"
     "\"option_keys\":[],\"option_values\":[]}}",
     handler.msg());
 
   // Invalid function request.
   service_msg = EvalF(h_lib, "[port, ['classes', '%" Pd "', 'functions', '9',"
                              "'x'], [], []]", cid);
   Service::HandleIsolateMessage(isolate, service_msg);
   handler.HandleNextMessage();
   EXPECT_STREQ(
     "{\"type\":\"Error\",\"text\":\"Command too long\",\"message\":"
-    "{\"arguments\":[\"classes\",\"1009\",\"functions\",\"9\",\"x\"],"
+    "{\"arguments\":[\"classes\",\"1010\",\"functions\",\"9\",\"x\"],"
     "\"option_keys\":[],\"option_values\":[]}}",
     handler.msg());
 }
 
 
 TEST_CASE(Service_Code) {
   const char* kScript =
       "var port;\n"  // Set to our mock port by C++.
       "\n"
       "class A {\n"
@@ skipping 173 matching lines @@
   handler.HandleNextMessage();
   EXPECT_SUBSTRING(
       "{\"source\":\"dart:test-lib\",\"script\":{"
       "\"type\":\"@Script\",\"id\":\"scripts\\/dart%3Atest-lib\","
       "\"name\":\"dart:test-lib\",\"user_name\":\"dart:test-lib\","
       "\"kind\":\"script\"},\"hits\":"
       "[3,0,3,1,5,1,5,1,5,1,6,1,6,1]}", handler.msg());
 }
 
 }  // namespace dart