Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1406413006: Timeline service protocol support with Observatory UI (Closed)

Created:
5 years, 1 month ago by Cutch
Modified:
5 years, 1 month ago
Reviewers:
turnidge, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Timeline service protocol support with Observatory UI Service Protocol: - _clearVMTimeline (clear timeline) - _getVMTimeline (fetch timeline) - _setVMTimelineFlag (control recording) - _getVMTimelineFlag (...) - _getVMTimeline service unit test Observatory: - timeline page with record on/off, clear timeline, and refresh buttons. - trace-viewer based timeline view that runs in an iframe driven by a small javascript program Misc: - Fix default enable logic bugs - Add 'Debugger Pause' timeline event - Threads can have a name and that name will be displayed in Observatory - Tighten up locking when printing JSON R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/43b0ae00e7d1024191c65fa6d4f63010afea5d86

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -226 lines) Patch
M runtime/include/dart_tools_api.h View 1 2 3 4 1 chunk +7 lines, -4 lines 0 comments Download
D runtime/observatory/README_android View 1 2 3 4 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/observatory/bin/server.dart View 1 2 3 4 1 chunk +0 lines, -159 lines 0 comments Download
M runtime/observatory/lib/elements.dart View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.html View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/timeline_page.dart View 1 2 3 4 1 chunk +78 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/timeline_page.html View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/observatory/pubspec.yaml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D runtime/observatory/run.sh View 1 2 3 4 1 chunk +0 lines, -25 lines 0 comments Download
A runtime/observatory/tests/service/get_vm_timeline_rpc_test.dart View 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/observatory/web/third_party/README.md View 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A runtime/observatory/web/timeline.html View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A runtime/observatory/web/timeline.js View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 4 chunks +92 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 1 2 3 4 3 chunks +19 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/thread_pool.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 1 2 3 4 6 chunks +10 lines, -5 lines 0 comments Download
M runtime/vm/timeline.cc View 1 2 3 4 9 chunks +46 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Cutch
5 years, 1 month ago (2015-11-03 14:47:00 UTC) #4
Cutch
@rmacnak- PTAL
5 years, 1 month ago (2015-11-09 17:55:13 UTC) #6
rmacnak
lgtm w/c https://codereview.chromium.org/1406413006/diff/30001/runtime/observatory/lib/src/elements/timeline_page.dart File runtime/observatory/lib/src/elements/timeline_page.dart (right): https://codereview.chromium.org/1406413006/diff/30001/runtime/observatory/lib/src/elements/timeline_page.dart#newcode20 runtime/observatory/lib/src/elements/timeline_page.dart:20: attached() { Weird spacing
5 years, 1 month ago (2015-11-09 18:59:06 UTC) #7
Cutch
https://codereview.chromium.org/1406413006/diff/30001/runtime/observatory/lib/src/elements/timeline_page.dart File runtime/observatory/lib/src/elements/timeline_page.dart (right): https://codereview.chromium.org/1406413006/diff/30001/runtime/observatory/lib/src/elements/timeline_page.dart#newcode20 runtime/observatory/lib/src/elements/timeline_page.dart:20: attached() { On 2015/11/09 18:59:06, rmacnak wrote: > Weird ...
5 years, 1 month ago (2015-11-10 15:59:24 UTC) #8
Cutch
5 years, 1 month ago (2015-11-10 16:02:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:50001) manually as
43b0ae00e7d1024191c65fa6d4f63010afea5d86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698