Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1406413003: Attempt to update Xfermode comments to have parallel structure. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Attempt to update Xfermode comments to have parallel structure. BUG=none TEST=none Committed: https://skia.googlesource.com/skia/+/129319ff55f4be826419ffa04e772e21c6b12400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/core/SkXfermode.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
I found myself struggling to understand how these modes related to each other, so I ...
5 years, 1 month ago (2015-10-28 23:33:18 UTC) #2
reed1
lgtm
5 years, 1 month ago (2015-10-29 15:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406413003/1
5 years, 1 month ago (2015-10-29 15:29:42 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 15:41:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/129319ff55f4be826419ffa04e772e21c6b12400

Powered by Google App Engine
This is Rietveld 408576698