ui/views/win/hwnd_message_handler.h - Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/win/hwnd_message_handler.h

Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add move semantics to ScopedGDIObject. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/win/scoped_gdi_object.h ('K') | « chrome/browser/ui/views/frame/glass_browser_frame_view.cc ('k') | ui/views/win/hwnd_message_handler.cc » ('j') | ui/views/win/hwnd_message_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/win/hwnd_message_handler.h

diff --git a/ui/views/win/hwnd_message_handler.h b/ui/views/win/hwnd_message_handler.h

index b24f5b9b21f46a3267f5e61919b89d1632c6f561..f0fb4d8c4a774d22af6e6158e43c27258a405129 100644

--- a/ui/views/win/hwnd_message_handler.h

+++ b/ui/views/win/hwnd_message_handler.h

@@ -517,6 +517,12 @@ class VIEWS_EXPORT HWNDMessageHandler :

// so that we can restore it.

HCURSOR previous_cursor_;

+ // The icon created from the bitmap image of the window icon.

+ base::win::ScopedHICON window_icon_;

+ // The icon created from the bitmap image of the app icon.

+ base::win::ScopedHICON app_icon_;

// Event handling ------------------------------------------------------------

// The flags currently being used with TrackMouseEvent to track mouse