ui/views/controls/menu/menu_config_win.cc - Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_config_win.cc

Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_config_win.cc

diff --git a/ui/views/controls/menu/menu_config_win.cc b/ui/views/controls/menu/menu_config_win.cc

index 0b69567480dfc8f04141edc64c467a152a5d8a74..48d520f8148155960aa8daa0273a5c191e1a4591 100644

--- a/ui/views/controls/menu/menu_config_win.cc

+++ b/ui/views/controls/menu/menu_config_win.cc

@@ -28,8 +28,8 @@ void MenuConfig::Init() {

l10n_util::AdjustUIFont(&(metrics.lfMenuFont));

{

base::win::ScopedHFONT new_font(CreateFontIndirect(&metrics.lfMenuFont));

- DLOG_ASSERT(new_font.Get());

- font_list = gfx::FontList(gfx::Font(new_font));

+ DLOG_ASSERT(new_font.is_valid());

+ font_list = gfx::FontList(gfx::Font(new_font.get()));

}

NativeTheme::ExtraParams extra;

extra.menu_check.is_radio = false;

« no previous file with comments | « ui/native_theme/native_theme_win.cc ('k') | ui/views/widget/native_widget_aura.cc » ('j') | no next file with comments »