ui/gfx/path_win.cc - Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/path_win.cc

Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/path_win.cc

diff --git a/ui/gfx/path_win.cc b/ui/gfx/path_win.cc

index e6a915b3306968b8133475aa68d16a613d8a2545..72f5191ccdf0e5e92d64efdd9c5dfe6daa18fada 100644

--- a/ui/gfx/path_win.cc

+++ b/ui/gfx/path_win.cc

@@ -17,8 +17,9 @@ HRGN CreateHRGNFromSkRegion(const SkRegion& region) {

for (SkRegion::Iterator i(region); !i.done(); i.next()) {

const SkIRect& rect = i.rect();

- ::SetRectRgn(temp, rect.left(), rect.top(), rect.right(), rect.bottom());

- ::CombineRgn(result, result, temp, RGN_OR);

+ ::SetRectRgn(temp.get(),

+ rect.left(), rect.top(), rect.right(), rect.bottom());

+ ::CombineRgn(result.get(), result.get(), temp.get(), RGN_OR);

}

return result.release();

« no previous file with comments | « ui/gfx/icon_util_unittest.cc ('k') | ui/gfx/path_win_unittest.cc » ('j') | no next file with comments »