ui/views/widget/native_widget_aura.cc - Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use ScopedHICON instead of HICON. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/native_widget_aura.cc

diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc

index 8099626710db18abf5751e2c015403307ec4ff92..ae12415fca0e48dfec85d5e240a0a6970cf5fc8c 100644

--- a/ui/views/widget/native_widget_aura.cc

+++ b/ui/views/widget/native_widget_aura.cc

@@ -1162,7 +1162,7 @@ gfx::FontList NativeWidgetPrivate::GetWindowTitleFontList() {

base::win::GetNonClientMetrics(&ncm);

l10n_util::AdjustUIFont(&(ncm.lfCaptionFont));

base::win::ScopedHFONT caption_font(CreateFontIndirect(&(ncm.lfCaptionFont)));

- return gfx::FontList(gfx::Font(caption_font));

+ return gfx::FontList(gfx::Font(caption_font.get()));

#else

return gfx::FontList();

#endif

« ui/gfx/icon_util_unittest.cc ('K') | « ui/views/controls/menu/menu_config_win.cc ('k') | ui/views/win/hwnd_message_handler.h » ('j') | no next file with comments »