Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Side by Side Diff: ui/views/win/hwnd_message_handler.h

Issue 1406403007: Eliminate HICON leaks caused by creating icons from bitmap image. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/views/win/hwnd_message_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_ 5 #ifndef UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_
6 #define UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_ 6 #define UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_
7 7
8 #include <windows.h> 8 #include <windows.h>
9 9
10 #include <set> 10 #include <set>
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 // true. 516 // true.
517 bool restored_enabled_; 517 bool restored_enabled_;
518 518
519 // The current cursor. 519 // The current cursor.
520 HCURSOR current_cursor_; 520 HCURSOR current_cursor_;
521 521
522 // The last cursor that was active before the current one was selected. Saved 522 // The last cursor that was active before the current one was selected. Saved
523 // so that we can restore it. 523 // so that we can restore it.
524 HCURSOR previous_cursor_; 524 HCURSOR previous_cursor_;
525 525
526 // The icon created from the bitmap image of the window icon.
527 base::win::ScopedHICON window_icon_;
528
529 // The icon created from the bitmap image of the app icon.
530 base::win::ScopedHICON app_icon_;
531
526 // Event handling ------------------------------------------------------------ 532 // Event handling ------------------------------------------------------------
527 533
528 // The flags currently being used with TrackMouseEvent to track mouse 534 // The flags currently being used with TrackMouseEvent to track mouse
529 // messages. 0 if there is no active tracking. The value of this member is 535 // messages. 0 if there is no active tracking. The value of this member is
530 // used when tracking is canceled. 536 // used when tracking is canceled.
531 DWORD active_mouse_tracking_flags_; 537 DWORD active_mouse_tracking_flags_;
532 538
533 // Set to true when the user presses the right mouse button on the caption 539 // Set to true when the user presses the right mouse button on the caption
534 // area. We need this so we can correctly show the context menu on mouse-up. 540 // area. We need this so we can correctly show the context menu on mouse-up.
535 bool is_right_mouse_pressed_on_caption_; 541 bool is_right_mouse_pressed_on_caption_;
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 639
634 // The factory used with BEGIN_SAFE_MSG_MAP_EX. 640 // The factory used with BEGIN_SAFE_MSG_MAP_EX.
635 base::WeakPtrFactory<HWNDMessageHandler> weak_factory_; 641 base::WeakPtrFactory<HWNDMessageHandler> weak_factory_;
636 642
637 DISALLOW_COPY_AND_ASSIGN(HWNDMessageHandler); 643 DISALLOW_COPY_AND_ASSIGN(HWNDMessageHandler);
638 }; 644 };
639 645
640 } // namespace views 646 } // namespace views
641 647
642 #endif // UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_ 648 #endif // UI_VIEWS_WIN_HWND_MESSAGE_HANDLER_H_
OLDNEW
« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/views/win/hwnd_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698