Eliminate HICON leaks caused by creating icons from bitmap image.

chrome/browser/ui/views/frame/glass_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/glass_browser_frame_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/windows_version.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 567 matching lines @@
     HICON big_icon = nullptr;
 
     // Check if hosted BrowserView has a window icon to use.
     if (browser_view()->ShouldShowWindowIcon()) {
       gfx::ImageSkia icon = browser_view()->GetWindowIcon();
       if (!icon.isNull()) {
         small_icon = CreateHICONFromSkBitmapSizedTo(
             icon, GetSystemMetrics(SM_CXSMICON), GetSystemMetrics(SM_CYSMICON));
         big_icon = CreateHICONFromSkBitmapSizedTo(
             icon, GetSystemMetrics(SM_CXICON), GetSystemMetrics(SM_CYICON));
+
+        // Take responsibility for eventually destroying the created icons.
+        small_window_icon_.Set(small_icon);

[sky, 2015/11/02 16:41:38]

Won't this be problematic with the code on 618-623?

Also, you should make CreateHICONFromSkBitmapSizedTo return a scopedHICON to
make ownership clear. I suspect this means adding move semantics to ScopedHICon,
but that's for the better.

+        big_window_icon_.Set(big_icon);
       }
     }
 
     // Fallback to class icon.
     if (!small_icon) {
       small_icon = reinterpret_cast<HICON>(
           GetClassLongPtr(views::HWNDForWidget(frame()), GCLP_HICONSM));
     }
     if (!big_icon) {
       big_icon = reinterpret_cast<HICON>(
@@ skipping 33 matching lines @@
   static bool initialized = false;
   if (!initialized) {
     for (int i = 0; i < kThrobberIconCount; ++i) {
       throbber_icons_[i] =
           ui::LoadThemeIconFromResourcesDataDLL(IDI_THROBBER_01 + i);
       DCHECK(throbber_icons_[i]);
     }
     initialized = true;
   }
 }