Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: runtime/lib/integers.cc

Issue 14064019: Allow leading + when parsing integers in fast case (it is allowed per library implementation, only … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers.cc
===================================================================
--- runtime/lib/integers.cc (revision 21775)
+++ runtime/lib/integers.cc (working copy)
@@ -189,15 +189,11 @@
if (len > 0) {
const char* cstr = value.ToCString();
ASSERT(cstr != NULL);
- // Dart differences from strtol:
- // a) '+5' is not a valid integer (leading plus).
- if (cstr[0] != '+') {
- char* p_end = NULL;
- const int64_t int_value = strtoll(cstr, &p_end, 10);
- if (p_end == (cstr + len)) {
- if ((int_value != LLONG_MIN) && (int_value != LLONG_MAX)) {
- return Integer::New(int_value);
- }
+ char* p_end = NULL;
+ const int64_t int_value = strtoll(cstr, &p_end, 10);
+ if (p_end == (cstr + len)) {
+ if ((int_value != LLONG_MIN) && (int_value != LLONG_MAX)) {
+ return Integer::New(int_value);
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698