Issue 14064014: Revert 193811 "Move browser and url to WebContents from Tab."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14064014: Revert 193811 "Move browser and url to WebContents from Tab." (Closed)

Created:
7 years, 8 months ago by achuithb

Modified:
7 years, 8 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 193811 "Move browser and url to WebContents from Tab." Reverting because url uses BrowserBackend.tab_list_backend, which is not correct for WebContents. > Move browser and url to WebContents from Tab. > > BUG=None > TEST=unit tests > NOTRY=true > > Review URL: https://chromiumcodereview.appspot.com/14185002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194978

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	trunk/src/tools/telemetry/telemetry/core/tab.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	trunk/src/tools/telemetry/telemetry/core/web_contents.py	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

tonyg

On 2013/04/18 00:08:44, achuith.bhandarkar wrote: > Please review. This needs to be reverted. lgtm for ...

7 years, 8 months ago (2013-04-18 02:16:25 UTC) #3

achuithb

7 years, 8 months ago (2013-04-18 18:50:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r194978 (presubmit successful).