Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 14064011: Add url/ to banned_directories in clang style checker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add TODO Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index f23f6e2c7a38f684d169bbb9d2d128896c7bf9ae..33b9f8e637744918a08df58885cc10d793387fdc 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -141,20 +141,22 @@ void ChromeClassTester::BuildBannedLists() {
banned_namespaces_.push_back("WebKit");
banned_namespaces_.push_back("WebTestRunner");
- banned_directories_.push_back("third_party/");
- banned_directories_.push_back("native_client/");
banned_directories_.push_back("breakpad/");
banned_directories_.push_back("courgette/");
+ banned_directories_.push_back("dart/");
+ banned_directories_.push_back("frameworks/");
+ banned_directories_.push_back("googleurl/");
+ banned_directories_.push_back("icu4c/");
+ banned_directories_.push_back("native_client/");
banned_directories_.push_back("pdf/");
banned_directories_.push_back("ppapi/");
- banned_directories_.push_back("usr/");
+ banned_directories_.push_back("sdch/");
banned_directories_.push_back("testing/");
- banned_directories_.push_back("googleurl/");
+ banned_directories_.push_back("third_party/");
+ // TODO(tfarina): Remove this when ready. crbug.com/229660
+ banned_directories_.push_back("url/");
Nico 2013/04/16 01:51:50 Do you want to put this behind a flag so that you
+ banned_directories_.push_back("usr/");
banned_directories_.push_back("v8/");
- banned_directories_.push_back("dart/");
- banned_directories_.push_back("sdch/");
- banned_directories_.push_back("icu4c/");
- banned_directories_.push_back("frameworks/");
// Don't check autogenerated headers.
// Make puts them below $(builddir_name)/.../gen and geni.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698