Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tools/clang/plugins/ChromeClassTester.h

Issue 14064011: Add url/ to banned_directories in clang style checker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chrome-plugins Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.h
diff --git a/tools/clang/plugins/ChromeClassTester.h b/tools/clang/plugins/ChromeClassTester.h
index 588ae9cae5a90fedbcc2c77ec6c19b8ea5609b6e..3380eda98cddf15a6c04201ef80588990543eba6 100644
--- a/tools/clang/plugins/ChromeClassTester.h
+++ b/tools/clang/plugins/ChromeClassTester.h
@@ -16,7 +16,8 @@
// headers to subclasses which implement CheckChromeClass().
class ChromeClassTester : public clang::ASTConsumer {
public:
- explicit ChromeClassTester(clang::CompilerInstance& instance);
+ explicit ChromeClassTester(clang::CompilerInstance& instance,
+ bool check_url_directory);
virtual ~ChromeClassTester();
// clang::ASTConsumer:
@@ -44,6 +45,9 @@ class ChromeClassTester : public clang::ASTConsumer {
// implementation (.cc, .cpp, .mm) file.
bool InImplementationFile(clang::SourceLocation location);
+ // TODO(tfarina): Remove once url/ directory compiles without warnings.
+ bool check_url_directory_;
Nico 2013/04/16 22:16:56 I think this can stay private. You only use this i
tfarina 2013/04/16 22:23:24 Done.
+
private:
void BuildBannedLists();
« no previous file with comments | « no previous file | tools/clang/plugins/ChromeClassTester.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698