Add url/ to banned_directories in clang style checker.

tools/clang/plugins/FindBadConstructs.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a bunch of recurring problems in the Chromium C++ code.
 //
 // Checks that are implemented:
 // - Constructors/Destructors should not be inlined if they are of a complex
 //   class type.
 // - Missing "virtual" keywords on methods that should be virtual.
@@ skipping 57 matching lines @@
   if (const TypedefType* typedefed = dyn_cast<TypedefType>(type))
     return UnwrapType(typedefed->desugar().getTypePtr());
   return type;
 }
 
 // Searches for constructs that we know we don't want in the Chromium code base.
 class FindBadConstructsConsumer : public ChromeClassTester {
  public:
   FindBadConstructsConsumer(CompilerInstance& instance,
                             bool check_base_classes,
-                            bool check_virtuals_in_implementations)
-      : ChromeClassTester(instance),
+                            bool check_virtuals_in_implementations,
+                            bool check_url_directory)
+      : ChromeClassTester(instance, check_url_directory),
         check_base_classes_(check_base_classes),
-        check_virtuals_in_implementations_(check_virtuals_in_implementations) {
+        check_virtuals_in_implementations_(check_virtuals_in_implementations),
+        check_url_directory_(check_url_directory) {

[Nico, 2013/04/16 15:31:11]

Do you need this part? You're already passing this to the superclass
constructor. (Also, the member in the superclass is private – does this even
build?)

     // Register warning/error messages.
     diag_method_requires_override_ = diagnostic().getCustomDiagID(
         getErrorLevel(), kMethodRequiresOverride);
     diag_method_requires_virtual_ = diagnostic().getCustomDiagID(
         getErrorLevel(), kMethodRequiresVirtual);
     diag_no_explicit_dtor_ = diagnostic().getCustomDiagID(
         getErrorLevel(), kNoExplicitDtor);
     diag_public_dtor_ = diagnostic().getCustomDiagID(
         getErrorLevel(), kPublicDtor);
     diag_protected_non_virtual_dtor_ = diagnostic().getCustomDiagID(
@@ skipping 520 matching lines @@
         PrintInheritanceChain(*it);
       }
     }
   }
 };
 
 class FindBadConstructsAction : public PluginASTAction {
  public:
   FindBadConstructsAction()
       : check_base_classes_(false),
-        check_virtuals_in_implementations_(true) {
+        check_virtuals_in_implementations_(true),
+        check_url_directory_(false) {
   }
 
  protected:
   // Overridden from PluginASTAction:
   virtual ASTConsumer* CreateASTConsumer(CompilerInstance& instance,
                                          llvm::StringRef ref) {
     return new FindBadConstructsConsumer(
-        instance, check_base_classes_, check_virtuals_in_implementations_);
+        instance, check_base_classes_, check_virtuals_in_implementations_,
+        check_url_directory_);
   }
 
   virtual bool ParseArgs(const CompilerInstance& instance,
                          const std::vector<std::string>& args) {
     bool parsed = true;
 
     for (size_t i = 0; i < args.size() && parsed; ++i) {
       if (args[i] == "skip-virtuals-in-implementations") {
         // TODO(rsleevi): Remove this once http://crbug.com/115047 is fixed.
         check_virtuals_in_implementations_ = false;
       } else if (args[i] == "check-base-classes") {
         // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
         check_base_classes_ = true;
+      } else if (args[i] == "check-url-directory") {
+        // TODO(tfarina): Remove this once http://crbug.com/229660 is fixed.
+        check_url_directory_ = true;
       } else {
         parsed = false;
         llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
       }
     }
 
     return parsed;
   }
 
  private:
   bool check_base_classes_;
   bool check_virtuals_in_implementations_;
+  bool check_url_directory_;
 };
 
 }  // namespace
 
 static FrontendPluginRegistry::Add<FindBadConstructsAction>
 X("find-bad-constructs", "Finds bad C++ constructs");