Clear StyleResolver state before returning from styleForElement().

Clear StyleResolver state before returning from styleForElement().

A cached element pointer in the resolver state was causing confusion because
in some cases a subsequent call to styleForElement() would use a pointer to
a different object that is at the same memory address as the previous one.

R=dglazkov@chromium.org
BUG=196393
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148687

[kenrb, 2013-04-17 15:27:57]

Julien are you able to review a small change to StyleResolver?

[dglazkov, 2013-04-17 17:42:43]

Aw jeez. LGTM.

[commit-bot: I haz the power, 2013-04-18 16:06:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenrb@chromium.org/14064008/1

[commit-bot: I haz the power, 2013-04-18 16:06:39]

Failed to apply patch for Source/WebCore/css/StyleResolver.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         Source/WebCore
  Created missing directory Source/WebCore.
  A         Source/WebCore/css
  Created missing directory Source/WebCore/css.
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/WebCore/css/StyleResolver.cpp
  |diff --git a/Source/WebCore/css/StyleResolver.cpp
b/Source/WebCore/css/StyleResolver.cpp
  |index
8e7e2fb5b584df92a4c239be15872925ad14495e..f0a864a36896048e8a5471be1e20f097ce0a1175
100644
  |--- a/Source/WebCore/css/StyleResolver.cpp
  |+++ b/Source/WebCore/css/StyleResolver.cpp
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/WebCore/css/StyleResolver.cpp
Index: Source/WebCore/css/StyleResolver.cpp
diff --git a/Source/WebCore/css/StyleResolver.cpp
b/Source/WebCore/css/StyleResolver.cpp
index
8e7e2fb5b584df92a4c239be15872925ad14495e..f0a864a36896048e8a5471be1e20f097ce0a1175
100644
--- a/Source/WebCore/css/StyleResolver.cpp
+++ b/Source/WebCore/css/StyleResolver.cpp
@@ -960,8 +960,10 @@ PassRefPtr<RenderStyle>
StyleResolver::styleForElement(Element* element, RenderS
     state.initForStyleResolve(document(), element, defaultParent,
regionForStyling);
     if (sharingBehavior == AllowStyleSharing &&
!state.distributedToInsertionPoint()) {
         RenderStyle* sharedStyle = locateSharedStyle();
-        if (sharedStyle)
+        if (sharedStyle) {
+            state.clear();
             return sharedStyle;
+        }
     }
 
     if (state.parentStyle()) {

[aarya, 2013-04-18 16:10:21]

WebCore has moved to core.

[commit-bot: I haz the power, 2013-04-18 17:29:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenrb@chromium.org/14064008/8001

[commit-bot: I haz the power, 2013-04-18 17:35:42]

Presubmit check for 14064008-8001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 3 file(s).

[commit-bot: I haz the power, 2013-04-18 18:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenrb@chromium.org/14064008/8001

[commit-bot: I haz the power, 2013-04-18 18:14:12]

Presubmit check for 14064008-8001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 3 file(s).

[commit-bot: I haz the power, 2013-04-18 19:43:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kenrb@chromium.org/14064008/8001

[commit-bot: I haz the power, 2013-04-18 19:49:57]

Presubmit check for 14064008-8001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 3 file(s).

[inferno, 2013-04-18 21:24:47]

Committed patchset #2 manually as r148687 (presubmit successful).