Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 1406393005: [test] Move away from deprecated API for heap-related tests. (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG=v8:4134 LOG=n Committed: https://crrev.com/aecd084dd96a26a8d55e8eb766d66d3cc968d98f Cr-Commit-Position: refs/heads/master@{#31898}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Move delta between last PS1 and PS2 to new API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -230 lines) Patch
M test/cctest/test-alloc.cc View 4 chunks +20 lines, -7 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 91 chunks +318 lines, -209 lines 0 comments Download
M test/cctest/test-incremental-marking.cc View 5 chunks +13 lines, -4 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/1
5 years, 1 month ago (2015-11-02 18:00:02 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 18:34:39 UTC) #4
Michael Lippautz
PTAL
5 years, 1 month ago (2015-11-02 19:17:31 UTC) #7
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-09 18:55:24 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/20001
5 years, 1 month ago (2015-11-09 19:18:41 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/6303) v8_linux_arm64_rel on ...
5 years, 1 month ago (2015-11-09 19:20:21 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
5 years, 1 month ago (2015-11-09 19:30:36 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 19:45:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
5 years, 1 month ago (2015-11-09 19:46:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
5 years, 1 month ago (2015-11-09 19:47:58 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-09 19:48:14 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 19:48:54 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aecd084dd96a26a8d55e8eb766d66d3cc968d98f
Cr-Commit-Position: refs/heads/master@{#31898}

Powered by Google App Engine
This is Rietveld 408576698