Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 1 month ago by Michael Lippautz Modified:
5 years, 1 month ago Reviewers:
Hannes Payer (out of office) CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Move away from deprecated API for heap-related tests.
Removed deprecated API usage in
- test-heap.cc
- test-incremental-marking.cc
- test-alloc.cc
BUG=v8:4134
LOG=n
Committed: https://crrev.com/aecd084dd96a26a8d55e8eb766d66d3cc968d98f
Cr-Commit-Position: refs/heads/master@{#31898}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Move delta between last PS1 and PS2 to new API #
Created: 5 years, 1 month ago
Messages
Total messages: 26 (14 generated)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [test] Move away from deprecated API for heap-realted tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG= ========== to ========== [test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG= ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
PTAL
lgtm
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/1406393005/#ps40001 (title: "Move delta between last PS1 and PS2 to new API")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
The CQ bit was unchecked by mlippautz@chromium.org
Description was changed from ========== [test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG= ========== to ========== [test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG=v8:4134 LOG=n ==========
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406393005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406393005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc BUG=v8:4134 LOG=n ========== to ========== [test] Move away from deprecated API for heap-related tests. Removed deprecated API usage in - test-heap.cc - test-incremental-marking.cc - test-alloc.cc - test-spaces.cc BUG=v8:4134 LOG=n ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/aecd084dd96a26a8d55e8eb766d66d3cc968d98f Cr-Commit-Position: refs/heads/master@{#31898} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
