Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp

Issue 1406363002: Don't bother passing -1 as the length to the CFX_ByteString ctor. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fpdfapi/fpdf_page.h" 7 #include "../../../include/fpdfapi/fpdf_page.h"
8 #include "../../../include/fpdfapi/fpdf_module.h" 8 #include "../../../include/fpdfapi/fpdf_module.h"
9 #include "../fpdf_page/pageint.h" 9 #include "../fpdf_page/pageint.h"
10 #include <limits.h> 10 #include <limits.h>
(...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 FX_DWORD dwObjNum = AddIndirectObject(pDict); 1101 FX_DWORD dwObjNum = AddIndirectObject(pDict);
1102 if (InsertNewPage(this, iPage, pDict, m_PageList) < 0) { 1102 if (InsertNewPage(this, iPage, pDict, m_PageList) < 0) {
1103 ReleaseIndirectObject(dwObjNum); 1103 ReleaseIndirectObject(dwObjNum);
1104 return NULL; 1104 return NULL;
1105 } 1105 }
1106 return pDict; 1106 return pDict;
1107 } 1107 }
1108 1108
1109 CPDF_Font* CPDF_Document::AddStandardFont(const FX_CHAR* font, 1109 CPDF_Font* CPDF_Document::AddStandardFont(const FX_CHAR* font,
1110 CPDF_FontEncoding* pEncoding) { 1110 CPDF_FontEncoding* pEncoding) {
1111 CFX_ByteString name(font, -1); 1111 CFX_ByteString name(font);
1112 if (PDF_GetStandardFontName(&name) < 0) 1112 if (PDF_GetStandardFontName(&name) < 0)
1113 return nullptr; 1113 return nullptr;
1114 return GetPageData()->GetStandardFont(name, pEncoding); 1114 return GetPageData()->GetStandardFont(name, pEncoding);
1115 } 1115 }
1116 1116
1117 void CPDF_Document::DeletePage(int iPage) { 1117 void CPDF_Document::DeletePage(int iPage) {
1118 CPDF_Dictionary* pRoot = GetRoot(); 1118 CPDF_Dictionary* pRoot = GetRoot();
1119 if (pRoot == NULL) { 1119 if (pRoot == NULL) {
1120 return; 1120 return;
1121 } 1121 }
(...skipping 17 matching lines...) Expand all
1139 void FPDFAPI_FlatPageAttr(CPDF_Dictionary* pPageDict, 1139 void FPDFAPI_FlatPageAttr(CPDF_Dictionary* pPageDict,
1140 const CFX_ByteStringC& name) { 1140 const CFX_ByteStringC& name) {
1141 if (pPageDict->KeyExist(name)) { 1141 if (pPageDict->KeyExist(name)) {
1142 return; 1142 return;
1143 } 1143 }
1144 CPDF_Object* pObj = FPDFAPI_GetPageAttr(pPageDict, name); 1144 CPDF_Object* pObj = FPDFAPI_GetPageAttr(pPageDict, name);
1145 if (pObj) { 1145 if (pObj) {
1146 pPageDict->SetAt(name, pObj->Clone()); 1146 pPageDict->SetAt(name, pObj->Clone());
1147 } 1147 }
1148 } 1148 }
OLDNEW
« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698