aura: Support SurfaceDestroyed() on Android

aura: Support SurfaceDestroyed() on Android

TBR=sky@chromium.org
BUG=513540
Committed: https://crrev.com/58f43364edf7789fe61ffd0e77284335d30d1ae3
Cr-Commit-Position: refs/heads/master@{#354809}

[no sievers, 2015-10-16 20:38:32]

sievers@chromium.org changed reviewers:
+ mfomitchev@chromium.org, sadrul@chromium.org

[no sievers, 2015-10-16 20:38:59]

ptal

https://codereview.chromium.org/1406333003/diff/1/ui/platform_window/android/...
File ui/platform_window/android/platform_window_android.cc (left):

https://codereview.chromium.org/1406333003/diff/1/ui/platform_window/android/...
ui/platform_window/android/platform_window_android.cc:93:
delegate_->OnAcceleratedWidgetAvailable(gfx::kNullAcceleratedWidget, 0.f);
kNullAcceleratedWidget might be used in tests and causes an offscreen surface to
be created, so comparing against that in WTH to trigger the release might not be
a good idea.

[mfomitchev, 2015-10-16 23:25:48]

LGTM

[sadrul, 2015-10-19 15:25:05]

lgtm

https://codereview.chromium.org/1406333003/diff/20001/ui/platform_window/plat...
File ui/platform_window/platform_window_delegate.h (right):

https://codereview.chromium.org/1406333003/diff/20001/ui/platform_window/plat...
ui/platform_window/platform_window_delegate.h:49: virtual void
OnAcceleratedWidgetDestroyed() = 0;
Can you add a comment here to document that OnAcceleratedWidgetDestroyed()
doesn't necessarily mean the PlatformWindow itself has been (or immediately
needs to be) destroyed, and OnAcceleratedWidgetAvailable() can be called again
on this window when it becomes available.

[no sievers, 2015-10-19 16:19:47]

https://codereview.chromium.org/1406333003/diff/20001/ui/platform_window/plat...
File ui/platform_window/platform_window_delegate.h (right):

https://codereview.chromium.org/1406333003/diff/20001/ui/platform_window/plat...
ui/platform_window/platform_window_delegate.h:49: virtual void
OnAcceleratedWidgetDestroyed() = 0;
On 2015/10/19 15:25:05, sadrul wrote:
> Can you add a comment here to document that OnAcceleratedWidgetDestroyed()
> doesn't necessarily mean the PlatformWindow itself has been (or immediately
> needs to be) destroyed, and OnAcceleratedWidgetAvailable() can be called again
> on this window when it becomes available.

Done.

[no sievers, 2015-10-19 16:21:56]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2015-10-19 16:21:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1406333003/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2015-10-19 16:22:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406333003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406333003/40001

[commit-bot: I haz the power, 2015-10-19 16:31:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 16:31:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no sievers, 2015-10-19 16:32:44]

Description was changed from

==========
aura: Support SurfaceDestroyed() on Android

BUG=513540
==========

to

==========
aura: Support SurfaceDestroyed() on Android

TBR=sky@chromium.org
BUG=513540
==========

[no sievers, 2015-10-19 16:32:58]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2015-10-19 16:34:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406333003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406333003/40001

[commit-bot: I haz the power, 2015-10-19 18:47:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-19 18:48:49]

Patchset 3 (id:??) landed as
https://crrev.com/58f43364edf7789fe61ffd0e77284335d30d1ae3
Cr-Commit-Position: refs/heads/master@{#354809}