media/video/capture/win/video_capture_device_win.cc - Issue 140633004: Reland CL to implement browser-side logging to WebRtc log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/win/video_capture_device_win.cc

Issue 140633004: Reland CL to implement browser-side logging to WebRtc log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: These are the changes that should fix crbug.com/338848 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/win/video_capture_device_win.cc

diff --git a/media/video/capture/win/video_capture_device_win.cc b/media/video/capture/win/video_capture_device_win.cc

index 48dd3daadc0a4b1646bb59ec8d6e482117ffe873..13d4d48cc640399e918dd43aa4de25ee1f49ca75 100644

--- a/media/video/capture/win/video_capture_device_win.cc

+++ b/media/video/capture/win/video_capture_device_win.cc

@@ -590,10 +590,10 @@ bool VideoCaptureDeviceWin::CreateCapabilityMap() {

return !capabilities_.empty();

}

-void VideoCaptureDeviceWin::SetErrorState(const char* reason) {

+void VideoCaptureDeviceWin::SetErrorState(const std::string& reason) {

DCHECK(CalledOnValidThread());

DVLOG(1) << reason;

state_ = kError;

- client_->OnError();

+ client_->OnError(reason);

}

} // namespace media