extensions/common/event_filtering_info.cc - Issue 140633003: Make EventFilteringInfo::IsEmpty() take has_instance_id_ into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/event_filtering_info.cc

Issue 140633003: Make EventFilteringInfo::IsEmpty() take has_instance_id_ into account. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/event_filtering_info.cc

diff --git a/extensions/common/event_filtering_info.cc b/extensions/common/event_filtering_info.cc

index cc46f969160750c332cc725b79b3fb57ff5120de..877f2c5caba9664feb9ba8a6b512fcbddb516369 100644

--- a/extensions/common/event_filtering_info.cc

+++ b/extensions/common/event_filtering_info.cc

@@ -46,7 +46,7 @@ scoped_ptr<base::Value> EventFilteringInfo::AsValue() const {

}

bool EventFilteringInfo::IsEmpty() const {

- return !has_url_ && service_type_.empty();

+ return !has_url_ && service_type_.empty() && !has_instance_id_;

}

} // namespace extensions

« no previous file with comments | « no previous file | no next file » | no next file with comments »