Async revalidation only applies to GET methods.

Async revalidation only applies to GET requests

BUG=348877
Committed: https://crrev.com/d97c21a2738efb1f2f0caf90bbc6be3c067cae21
Cr-Commit-Position: refs/heads/master@{#361318}

[cbentzel, 2015-10-20 12:15:52]

cbentzel@chromium.org changed reviewers:
+ ricea@chromium.org

[cbentzel, 2015-10-20 12:15:52]

Looking at design doc as well as HttpCache::Transaction::BeginRequestHeaders, we
only expect VALIDATION_ASYNCHRONOUS on GET methods.

[cbentzel, 2015-10-20 13:38:19]

On 2015/10/20 12:15:52, cbentzel wrote:
> Looking at design doc as well as HttpCache::Transaction::BeginRequestHeaders,
we
> only expect VALIDATION_ASYNCHRONOUS on GET methods.

I'll also see if I can add a unit test as well, surprised that this change
didn't trigger any warnings.

[Adam Rice, 2015-10-20 23:09:26]

On 2015/10/20 13:38:19, cbentzel wrote:
> On 2015/10/20 12:15:52, cbentzel wrote:
> > Looking at design doc as well as
HttpCache::Transaction::BeginRequestHeaders,
> we
> > only expect VALIDATION_ASYNCHRONOUS on GET methods.
> 
> I'll also see if I can add a unit test as well, surprised that this change
> didn't trigger any warnings.

Thank you for the fix. The old implementation supported HEAD for completeness,
but I'm not sure it was ever tested. The new implementation only supports GET,
since supporting HEAD doesn't solve any interesting problems.

LGTM.

[Adam Rice, 2015-11-24 10:14:50]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2015-11-24 10:15:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406323003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406323003/1

[commit-bot: I haz the power, 2015-11-24 11:37:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-24 11:38:16]

Patchset 1 (id:??) landed as
https://crrev.com/d97c21a2738efb1f2f0caf90bbc6be3c067cae21
Cr-Commit-Position: refs/heads/master@{#361318}