Issue 1406323002: Revert "add gflags to deps to allow command line parameters."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406323002: Revert "add gflags to deps to allow command line parameters." (Closed)

Created:
5 years, 2 months ago by kjellander_chromium

Modified:
5 years, 1 month ago

Reviewers:
fbarchard

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

Revert "add gflags to deps to allow command line parameters." This reverts commit 2dd3d9230ee663e71ed4ad9164033ed672e571de. Reason: chromium_git is a missing variable, and to properly add gflags, we need to check in GYP files in third_party/gflags first, then add the DEPS entry. BUG=libyuv:507 TBR=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/f80cc26da78b8221c235875e5954b5e647426640

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -12 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

kjellander_chromium

Committed patchset #1 (id:1) manually as f80cc26da78b8221c235875e5954b5e647426640 (presubmit successful).

5 years, 2 months ago (2015-10-16 19:47:04 UTC) #3

Message was sent while issue was closed.

lgtm