Adding Default Handlers from SpawnedTestServer to EmbeddedTestServer

net/test/embedded_test_server/default_handlers.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_TEST_EMBEDDED_TEST_SERVER_DEFAULT_HANDLERS_H_
+#define NET_TEST_EMBEDDED_TEST_SERVER_DEFAULT_HANDLERS_H_
+
+#include "net/test/embedded_test_server/embedded_test_server.h"

[Bence, 2015/10/27 14:47:36]

Move this include to .cc and add forward declaration, since only pointer to
EmbeddedTestServer is used in this header file.

[svaldez, 2015/10/27 15:00:50]

We can't forward declare EmbeddedTestServer because of how its namespace is
currently defined as part of the migration from net::test_server:: to net::.

[Bence, 2015/10/27 15:13:19]

Sorry, I don't quite understand that.  Could you not just forward declare it in
the appropriate namespace, and when you move the declaration into a different
namespace, move the forward declaration accordingly?  Or if it's not possible in
this CL, could it be done in the future, in which case it might make sense to
add a TODO?

+
+namespace net {
+namespace test_server {
+
+// This file is only meant for compatibility with testserver.py. No
+// additional handlers should be added here that don't affect multiple
+// distinct tests.
+
+// Registers default handlers for use in tests.
+void RegisterDefaultHandlers(EmbeddedTestServer* server);
+
+}  // namespace test_server
+}  // namespace net
+
+#endif  // NET_TEST_EMBEDDED_TEST_SERVER_DEFAULT_HANDLERS_H_