Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1406303008: Introduce new API for detecting when the embedder is in foreground/background. (Closed)

Created:
5 years, 2 months ago by ulan
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce new API for detecting when the embedder is in foreground/background. This will allow us to remove background idle notification calls in Chrome. BUG=chromium:490559 LOG=NO Committed: https://crrev.com/527a94017af8f25d7033b532c377a4fa0041c82c Cr-Commit-Position: refs/heads/master@{#31464}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M include/v8.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL
5 years, 2 months ago (2015-10-21 16:26:31 UTC) #2
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/1406303008/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1406303008/diff/1/include/v8.h#newcode5795 include/v8.h:5795: * V8 uses these notifications to guide the ...
5 years, 2 months ago (2015-10-22 10:40:55 UTC) #3
ulan
https://codereview.chromium.org/1406303008/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1406303008/diff/1/include/v8.h#newcode5795 include/v8.h:5795: * V8 uses these notifications to guide the GC ...
5 years, 2 months ago (2015-10-22 10:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406303008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406303008/20001
5 years, 2 months ago (2015-10-22 10:45:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 11:09:06 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 11:09:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/527a94017af8f25d7033b532c377a4fa0041c82c
Cr-Commit-Position: refs/heads/master@{#31464}

Powered by Google App Engine
This is Rietveld 408576698