Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1406303007: Drop SVGGraphicsElement.getTransformToElement (Closed)

Created:
5 years, 2 months ago by Shanmuga Pandi
Modified:
5 years, 1 month ago
Reviewers:
chrishtr, rwlbuis, pdr., fs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop SVGGraphicsElement.getTransformToElement Drop SVGGraphicsElement.getTransformToElement as on SVG WG F2F: https://lists.w3.org/Archives/Public/www-svg/2015Aug/att-0009/SVGWG-F2F-minutes-20150824.html#item02 BUG=524432 Committed: https://crrev.com/f7dafa91c1745acecc30c5cede04429163814a77 Cr-Commit-Position: refs/heads/master@{#357135}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed small nits #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -420 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/animations/animate-elem-06-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/svg/custom/getTransformToElement-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/svg/custom/getTransformToElement-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/animations/animate-elem-08-t-drt-expected.txt View 1 chunk +48 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/svg/custom/getTransformToElement-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/svg/custom/getTransformToElement-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win-xp/svg/animations/animate-elem-06-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/svg/custom/getTransformToElement-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/svg/custom/getTransformToElement-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/animations/animate-elem-08-t-drt-expected.txt View 1 chunk +48 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/svg/custom/getTransformToElement-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/svg/custom/getTransformToElement-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-01-b.svg View 4 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/types-basicDOM-01-b.svg View 4 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-04-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-05-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-06-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-07-t-drt-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-09-t-drt-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-10-t-drt-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-11-t-drt-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animate-elem-12-t-drt-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animateTransform-translate-attributetype-auto-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/animateTransform-translate-invalid-attributetype-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/resources/SVGAnimationTestCase.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-04-t-drt.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-05-t-drt.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-06-t-drt.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-07-t-drt.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-08-t-drt.js View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-09-t-drt.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-10-t-drt.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-11-t-drt.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animate-elem-12-t-drt.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animateTransform-translate-attributetype-auto.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/script-tests/animateTransform-translate-invalid-attributetype.js View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/get-text-element-transform-crash.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/get-text-element-transform-crash-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/custom/getTransformToElement.svg View 1 chunk +0 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/css-transforms.xhtml View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/css-transforms-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/selection-tripleclick.svg View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (12 generated)
rwlbuis
On 2015/10/21 14:00:44, Shanmuga Pandi wrote: > mailto:shanmuga.m@samsung.com changed reviewers: > + mailto:rob.buis@samsung.com Looks good ...
5 years, 2 months ago (2015-10-21 14:06:28 UTC) #3
rwlbuis
@pdr this looks fine to me, I think it needs an Intent to remove?
5 years, 2 months ago (2015-10-21 14:07:14 UTC) #5
pdr.
This looks good to me too. Can you please send an "intent to deprecate and ...
5 years, 2 months ago (2015-10-21 17:17:10 UTC) #6
Shanmuga Pandi
On 2015/10/21 17:17:10, pdr wrote: > This looks good to me too. Can you please ...
5 years, 1 month ago (2015-10-27 05:35:43 UTC) #7
Shanmuga Pandi
https://codereview.chromium.org/1406303007/diff/1/third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl File third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl (right): https://codereview.chromium.org/1406303007/diff/1/third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl#newcode44 third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl:44: }; On 2015/10/21 17:17:10, pdr wrote: > Nit: remove ...
5 years, 1 month ago (2015-10-27 05:35:55 UTC) #8
pdr.
On 2015/10/27 at 05:35:55, shanmuga.m wrote: > https://codereview.chromium.org/1406303007/diff/1/third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl > File third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl (right): > > https://codereview.chromium.org/1406303007/diff/1/third_party/WebKit/Source/core/svg/SVGGraphicsElement.idl#newcode44 ...
5 years, 1 month ago (2015-10-28 18:49:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406303007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406303007/20001
5 years, 1 month ago (2015-10-29 11:43:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/116285) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-29 11:45:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406303007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406303007/40001
5 years, 1 month ago (2015-10-29 13:12:24 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/113860)
5 years, 1 month ago (2015-10-29 13:19:54 UTC) #20
Shanmuga Pandi
** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt Missing LGTM ...
5 years, 1 month ago (2015-10-29 13:22:04 UTC) #21
pdr.
+cc chrishtr for API_OWNERS
5 years, 1 month ago (2015-10-30 01:57:00 UTC) #23
chrishtr
lgtm
5 years, 1 month ago (2015-10-30 16:16:41 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406303007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406303007/40001
5 years, 1 month ago (2015-10-30 16:17:36 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 18:29:58 UTC) #27
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:31:34 UTC) #28
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f7dafa91c1745acecc30c5cede04429163814a77
Cr-Commit-Position: refs/heads/master@{#357135}

Powered by Google App Engine
This is Rietveld 408576698