Issue 1406303006: Merge to XFA: Don't bother passing -1 as the length to the CFX_ByteString ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406303006: Merge to XFA: Don't bother passing -1 as the length to the CFX_ByteString ctor. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Don't bother passing -1 as the length to the CFX_ByteString ctor. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1406363002 . (cherry picked from commit 316e482630d5f5d9084edd9725f98a0d89a5bbdf) Committed: https://pdfium.googlesource.com/pdfium/+/0c6e6824979c9a3e7006a925f7b307db04342146

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -12 lines)			Patch
M	core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fpdftext/fpdf_text.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_fontmap.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/win32/fx_win32_device.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-16 23:30:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0c6e6824979c9a3e7006a925f7b307db04342146 (presubmit successful).