Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/automation/testing_automation_provider_chromeos.cc

Issue 14063017: Move logic in UserImageScreen from UserImageScreenHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Whitespaces and braces Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider_chromeos.cc
diff --git a/chrome/browser/automation/testing_automation_provider_chromeos.cc b/chrome/browser/automation/testing_automation_provider_chromeos.cc
index ce7d871d9f406836d8e4eb792834176ac23b1644..3dbd7920826d3643e0b19b748c2b17c6d5b03d90 100644
--- a/chrome/browser/automation/testing_automation_provider_chromeos.cc
+++ b/chrome/browser/automation/testing_automation_provider_chromeos.cc
@@ -390,10 +390,11 @@ void TestingAutomationProvider::PickUserImage(DictionaryValue* args,
WizardControllerObserver* observer =
new WizardControllerObserver(wizard_controller, this, reply_message);
if (image_type == "profile") {
- image_screen->OnProfileImageSelected();
+ image_screen->OnImageSelected("", image_type);
Nikita (slow) 2013/04/17 20:28:04 Why this call is changed?
Denis Kuznetsov (DE-MUC) 2013/04/18 02:57:50 Because screen does not have now separate methods
Denis Kuznetsov (DE-MUC) 2013/04/18 02:57:50 On 2013/04/17 20:28:04, Nikita Kostylev wrote: > W
Denis Kuznetsov (DE-MUC) 2013/04/18 03:00:16 And it should actually be followed by image_screen
} else if (image_type.empty() && image_number >= 0 &&
image_number < chromeos::kDefaultImagesCount) {
- image_screen->OnDefaultImageSelected(image_number);
+ image_screen->OnImageSelected(
+ chromeos::GetDefaultImageUrl(image_number), image_type);
} else {
AutomationJSONReply(this, reply_message).SendError(
"Invalid or missing args.");

Powered by Google App Engine
This is Rietveld 408576698